Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests against FluentCard and other fixes #310

Merged
merged 5 commits into from
Feb 6, 2023

Conversation

Andras-Csanyi
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi commented Feb 5, 2023

Pull Request

πŸ“– Description

This Pr contains the following changes:

  • bunit render tests against FluentCard, the tests checking the rendered HTML
  • Target parameter input validation for FluentAnchor and tests extended accordingly
  • FluentBadge appearance input parameter validation tests
  • Target parameter input validation for FluentBreadcrumbItem and tests extended accordingly

🎫 Issues

  • there are no related issues

πŸ‘©β€πŸ’» Reviewer Notes

  • I apologise in advance because I feel that this PR might be bigger/wider than it should be, I wanted to make these changes in one go
  • in case of FluentAnchor and FluentBreadcrimbItem Target parameter validation I followed the pattern I found at other components, however I see the opportunity to extract Target possible values and use this common list across components
  • the build of this PR will display warnings until Fix: warnings in Calendar and Button testsΒ #309 is not merged, once it is merged warnings should disappear

πŸ“‘ Test Plan

  • the component changes come with their tests

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have modified an existing component

⏭ Next Steps

@vnbaaij vnbaaij merged commit d19bc10 into microsoft:main Feb 6, 2023
@Andras-Csanyi Andras-Csanyi deleted the tests_and_fixes branch February 12, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants