Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NumberFieldDefault.razor #395

Merged
merged 8 commits into from
May 17, 2023
Merged

Update NumberFieldDefault.razor #395

merged 8 commits into from
May 17, 2023

Conversation

Ogglas
Copy link
Contributor

@Ogglas Ogglas commented May 17, 2023

Pull Request

πŸ“– Description

Based on discussion with @vnbaaij here: #389. For oninput versions the following bug is fixed as well: #394.

Removed component only used on https://www.fluentui-blazor.net/ to prevent multiple components.

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have modified an existing component

⏭ Next Steps

@Ogglas
Copy link
Contributor Author

Ogglas commented May 17, 2023

@microsoft-github-policy-service agree

@vnbaaij
Copy link
Collaborator

vnbaaij commented May 17, 2023

Can you also fix #393 in this patch? It's a very small fix but I'm not on main branch right now. Thanks!

@Ogglas
Copy link
Contributor Author

Ogglas commented May 17, 2023

@vnbaaij Sure, fixed now

@vnbaaij
Copy link
Collaborator

vnbaaij commented May 17, 2023

Can I ask for one more pleaseπŸ™‹β€β™‚οΈ
In examples/FluentUI.Demo.Shared/Pages/DataGrid/Examples/DataGridVirtualize.razor, both <ColumnOptions> can be removed as they don't do anything. They were just there for testing layout. This would fix your #392

@Ogglas
Copy link
Contributor Author

Ogglas commented May 17, 2023

@vnbaaij Sure :) Fixed #392 now.

@vnbaaij vnbaaij merged commit f27294c into microsoft:main May 17, 2023
3 of 4 checks passed
@Ogglas Ogglas deleted the patch-3 branch May 17, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants