Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NumberFieldDefault.razor #398

Merged
merged 8 commits into from
May 19, 2023
Merged

Update NumberFieldDefault.razor #398

merged 8 commits into from
May 19, 2023

Conversation

Ogglas
Copy link
Contributor

@Ogglas Ogglas commented May 17, 2023

Pull Request

πŸ“– Description

🎫 Issues

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have modified an existing component

⏭ Next Steps

@vnbaaij
Copy link
Collaborator

vnbaaij commented May 17, 2023

I assume you'll have more changes coming in for this one?

@Ogglas
Copy link
Contributor Author

Ogglas commented May 17, 2023

@vnbaaij Complete now. Fixing UI layout

image

@vnbaaij
Copy link
Collaborator

vnbaaij commented May 19, 2023

Hi Oscar, is this ready to merge?

@Ogglas
Copy link
Contributor Author

Ogglas commented May 19, 2023

Hi Oscar, is this ready to merge?

Hi Vincent,

Yes it is

@vnbaaij vnbaaij merged commit 0768622 into microsoft:main May 19, 2023
4 checks passed
@Ogglas Ogglas deleted the patch-4 branch May 19, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants