-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples and documentation for the Persona component. #843
Add examples and documentation for the Persona component. #843
Conversation
@microsoft-github-policy-service agree |
d1e24f3
to
de24423
Compare
Bonjour Gilles, Why do you want to add these samples? We already have a sample and doc on the Autocomplete page. Is it not enough ? |
examples/Demo/Shared/Pages/Persona/Examples/PersonaDefault.razor
Outdated
Show resolved
Hide resolved
Status="PresenceStatus.Available" | ||
StatusSize="PresenceBadgeSize.Small" | ||
StatusTitle="He is available" | ||
Image="https://res-1.cdn.office.net/files/fabric-cdn-prod_20230815.002/office-ui-fabric-react-assets/persona-male.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same... Could you use the @DataSource.SamplePicture
image? To be independent of external resources (which can be removed later)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed both remarks.
Hello Denis, I didn't remark that I really like the Fluent UI Blazor components library website, because it contains a good documentation and demo for each components. I find it a shame that some components are hidden (mixed) with other components and not visible in the navigation bar on the left. The navigation bar on the left, should reflect all the components available in the Blazor library to show to the developers, all the features of this library... |
Yes, you're probably right. We could add these example pages for greater clarity. |
* fix: chinese abbreviated day name in FluentCalendar (#834) * Minor documentation corrections (#837) * Fix #836 * fix NavMenuLink width * Rename solution file * FluentMenu: move overlay into anchored section code * Update version on index page * Update Menu example * Add some (π) more tests * [Unit Tests] Add Unit Tests in .razor files (#844) * Fix gitignore * Add FluentBadgeTests.razor * Fix #845 Exception with NavMenuLink * Fix #841 (#842) * Hide collapse button on demo site menu and remove some commented code * Fix #851 * Fix #852 * Update Fluent UI System Icons to 1.1.220 (#854) * Small ToC script optimization * Use latest SDKs * Make demos better when opening in light/dark mode * Fix initial theme switch setting * Fix: Add '@' to keyframe for fade-out animation (#855) * MessageBar: fix fadein effect * [Accessibility] Fix some FluentButton and FluentNav aria attributes (#853) * Fix FluentButton aria-label based on Title * Fix NavMenu aria * Fix Button Titles * Fix unit Tests * Add examples and documentation for the Persona component. (#843) * Fix the Persona samples to use "@DataSource.SamplePicture" instead of using external resources. * [Autocomplete] Update some Accessibility issues (#866) * Update Autocomplete Accessibility items * Fix Enter key when popup is closed * Update Previous and Next titles (and Unit Tests) * [FluentGrid] Add FluentGridItem with no breakpoints (#862) * Add FluentGridItem with no breakpoints * Update FluentValidationSummary.razor * Fix #865 * docs: Update sample InputFileDefault.razor (#867) * Update InputFileDefault.razor * Update InputFileByCode.razor * Update the documentation: inverse Api and Example sections * fix: Implement DesignToken.WithDefault and use in Demo site (#869) * Add 'System' option to theme settings * Fix aria-orientation (#877) * Fix #861 and also fix rendering in case of manual grid (#874) * Fix security scanning workflow * Add @ref to some layout components and adjust css of those to use css vars for font properties * Update WhatsNew * Update docs
Pull Request
π Description
Add examples and documentation for the
Persona
component.π©βπ» Reviewer Notes
Persona
item in the navigation menu.β Checklist
General