Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples and documentation for the Persona component. #843

Merged

Conversation

GillesTourreau
Copy link
Contributor

Pull Request

πŸ“– Description

Add examples and documentation for the Persona component.

πŸ‘©β€πŸ’» Reviewer Notes

  • I did not make changes to the component, I just add example in the demo project.
  • I added a Persona item in the navigation menu.
  • Do not hesitate to fix my english (I am native french guy... πŸ˜†).

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@GillesTourreau
Copy link
Contributor Author

@microsoft-github-policy-service agree

@dvoituron
Copy link
Collaborator

Bonjour Gilles,

Why do you want to add these samples? We already have a sample and doc on the Autocomplete page. Is it not enough ?

Status="PresenceStatus.Available"
StatusSize="PresenceBadgeSize.Small"
StatusTitle="He is available"
Image="https://res-1.cdn.office.net/files/fabric-cdn-prod_20230815.002/office-ui-fabric-react-assets/persona-male.png"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same... Could you use the @DataSource.SamplePicture image? To be independent of external resources (which can be removed later)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed both remarks.

@GillesTourreau
Copy link
Contributor Author

Bonjour Gilles,

Why do you want to add these samples? We already have a sample and doc on the Autocomplete page. Is it not enough ?

Hello Denis,

I didn't remark that Persona component was included in the Autocomplete demo page. My co-workers and me, we discovered this component in the demo website for React with a simple search on Google... And after investigation we discovered this component by searching the class in the NuGet package...

I really like the Fluent UI Blazor components library website, because it contains a good documentation and demo for each components. I find it a shame that some components are hidden (mixed) with other components and not visible in the navigation bar on the left. The navigation bar on the left, should reflect all the components available in the Blazor library to show to the developers, all the features of this library...

@dvoituron
Copy link
Collaborator

Yes, you're probably right. We could add these example pages for greater clarity.

@dvoituron dvoituron merged commit a88d671 into microsoft:dev Oct 14, 2023
4 checks passed
@GillesTourreau GillesTourreau deleted the users/add-persona-component-doc branch October 15, 2023 13:47
vnbaaij added a commit that referenced this pull request Oct 23, 2023
* fix: chinese abbreviated day name in FluentCalendar (#834)
* Minor documentation corrections (#837)
* Fix #836
* fix NavMenuLink width
* Rename solution file
* FluentMenu: move overlay into anchored section code
* Update version on index page
* Update Menu example
* Add some (πŸ˜‰) more tests
* [Unit Tests] Add Unit Tests in .razor files (#844)
* Fix gitignore
* Add FluentBadgeTests.razor
* Fix #845 Exception with NavMenuLink
* Fix #841 (#842)
* Hide collapse button on demo site menu and remove some commented code
* Fix #851
* Fix #852
* Update Fluent UI System Icons to 1.1.220 (#854)
* Small ToC script optimization
* Use latest SDKs
* Make demos better when opening in light/dark mode
* Fix initial theme switch setting
* Fix: Add '@' to keyframe for fade-out animation (#855)
* MessageBar: fix fadein effect
* [Accessibility] Fix some FluentButton and FluentNav aria attributes (#853)
* Fix FluentButton aria-label based on Title
* Fix NavMenu aria
* Fix Button Titles
* Fix unit Tests
* Add examples and documentation for the Persona component. (#843)
* Fix the Persona samples to use "@DataSource.SamplePicture" instead of using external resources.
* [Autocomplete] Update some Accessibility issues (#866)
* Update Autocomplete Accessibility items
* Fix Enter key when popup is closed
* Update Previous and Next titles (and Unit Tests)
* [FluentGrid] Add FluentGridItem with no breakpoints (#862)
* Add FluentGridItem with no breakpoints
* Update FluentValidationSummary.razor
* Fix #865
* docs: Update sample InputFileDefault.razor (#867)
* Update InputFileDefault.razor
* Update InputFileByCode.razor
* Update the documentation: inverse Api and Example sections
* fix: Implement DesignToken.WithDefault and use in Demo site (#869)
* Add 'System' option to theme settings
* Fix aria-orientation (#877)
* Fix #861 and also fix rendering in case of manual grid (#874)
* Fix security scanning workflow
* Add @ref to some layout components and adjust css of those to use css vars for font properties
* Update WhatsNew
* Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants