Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(azure-theme): bootstrap new package #180

Merged
merged 6 commits into from
May 23, 2024
Merged

feat(azure-theme): bootstrap new package #180

merged 6 commits into from
May 23, 2024

Conversation

Jacqueline-ms
Copy link
Contributor

@Jacqueline-ms Jacqueline-ms commented May 21, 2024 •
edited
Loading

Per documentation, initial PR introduces scaffolding.
Logic to come in next PR.

Original PR: #177

@Jacqueline-ms Jacqueline-ms requested a review from a team as a code owner May 21, 2024 19:24
@Jacqueline-ms Jacqueline-ms mentioned this pull request May 21, 2024
Closed
@tudorpopams tudorpopams requested a review from Hotell May 22, 2024 12:03
@Hotell Hotell changed the title Azure Theme scaffolding feat(azure-theme): bootstrap new package May 22, 2024
@Hotell
Copy link
Contributor

Hotell commented May 22, 2024

as part of boostraping I'd suggest to include storybook as well yarn nx generate @fluentui-contrib/nx-plugin:configure-storybook --name=azure-theme

@Jacqueline-ms
Copy link
Contributor Author

Thanks @Hotell . I included the component commands yarn nx generate component <name> <componentName> for our 3 subthemes: azure light, azure dark, azure high contrast.

@Jacqueline-ms Jacqueline-ms merged commit 2125d9f into microsoft:main May 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hotell Hotell Hotell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jacqueline-ms @Hotell