fix(nx-plugin): resolve new swc transpilation regression within build executor #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
Hotell
commented
Jul 12, 2024
| "semver": "^7.5.2", | ||
| "@nx/devkit": "^17.3.0", |
Hotell
commented
Jul 12, 2024
| context.projectsConfigurations.projects[context.projectName]; | ||
|
|
||
| const { root: workspaceRoot } = context; | ||
| const paths = getPackagePaths(workspaceRoot, root); | ||
| if (!projectConfig) { |
There was a problem hiding this comment.
changed validation logic - we care only if project exists or not
Hotell
commented
Jul 12, 2024
| function copyPackageJson(paths: PackagePaths) { | ||
| const packageJson = readJsonFile(paths.packageJson); | ||
| Object.assign(packageJson, { | ||
| types: './src/index.d.ts', |
There was a problem hiding this comment.
dupe for tsc d.ts type retrieval - unified with fluent core
Hotell
commented
Jul 12, 2024
| dist: path.join(workspaceRoot, 'dist', rootPath), | ||
| esm: path.join(workspaceRoot, 'dist', rootPath, 'lib'), | ||
| commonjs: path.join(workspaceRoot, 'dist', rootPath, 'lib-commonjs'), | ||
| main: joinPathFragments(rootPath, 'src', 'index.ts'), |
There was a problem hiding this comment.
less repetition - DRY
tudorpopams
approved these changes
Jul 15, 2024
mainframev
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New behaviour:
build executor uses new swc cli argument https://swc.rs/docs/usage/cli#--strip-leading-paths in order to mitiage regression that will create build assets within provided source root
force generated change file for resize-handler in order to trigger new release for affected package
added tests for build executor