-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build logic to a real build system #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments left about the extraneous change file conversion scripts. In general, looks okay... since they're from UI Fabric web :)
import { mergeSettings } from '@uifabric/theme-settings'; | ||
import { useAsPressable } from '../Pressable'; | ||
import { useAsPressable } from '../Pressable/index'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, are these changes really needed? We shouldn't need to specify index like this. If we find that the compilation fails because of this, we should fix the configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point I was hitting errors saying that these weren't targeting a physical file. I think in Fabric there is a forwarding file for controls. So there is a Pressable.ts that imports Pressable/index (I think).
This changes the build logic to use just + beachball. The initial source was copied from fabric but the change has some additional twists:
This also includes the incremental build support Ken added for Fabric with his lerna change. Now builds will clean, lint, build, test, and run webpack.
It is likely there are still places where the build logic can be simplified to be closer to standard approaches. Wherever we can cut things out we should unless there is a good reason for them.
Issues fixed in this change:
I also opened Issue #16 to cover switching from tslint to eslint