Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split types out of theming-ramp into new theme types package #463

Merged
merged 5 commits into from
Sep 18, 2020
Merged

Split types out of theming-ramp into new theme types package #463

merged 5 commits into from
Sep 18, 2020

Conversation

JasonVMo
Copy link
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32
  • windows
  • android

Description of changes

This creates a new package, @fluentui-react-native/theme-types that contains all of the typing information for the theme. This has a number of benefits:

  • The package is typing only, which means that it can be imported with a minimal impact on bundle size if someone only needs the types
  • This also allows the opportunity to explore alternative implementations for the theming parts without messing with the core packages

Verification

This should be mechanical (I know, famous last words) so automated tests should be sufficient

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@JasonVMo JasonVMo added the AutoMerge 🔁 Automatically merge when PR requirements met label Sep 18, 2020
@ghost
Copy link

ghost commented Sep 18, 2020

Hello @JasonVMo!

Because this pull request has the AutoMerge :repeat: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 53 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@JasonVMo JasonVMo merged commit 988fdbc into microsoft:master Sep 18, 2020
@JasonVMo JasonVMo deleted the theme-types branch September 18, 2020 21:40
@JasonVMo JasonVMo removed the AutoMerge 🔁 Automatically merge when PR requirements met label Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants