Automating the publish of flutter package on pub.dev #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willhou
reviewed
Nov 7, 2020
|
|
||
| # TODO: https://github.com/microsoft/fluentui-system-icons/issues/34 | ||
| # - name: Build Flutter library | ||
| # uses: ? |
There was a problem hiding this comment.
We should run the flutter build command here to ensure the library builds without failure.
There was a problem hiding this comment.
Added the dry run script to make sure that package is built properly but not publish. Let me know what you think about that :)
There was a problem hiding this comment.
ok, but for dry run, does it need the accessToken and refreshToken? Could we remove them if possible?
There was a problem hiding this comment.
It seems accessToken and refreshToken are required for the dry-run . Just tested without that and it failed.
|
Can you fill out the PR description? Thanks. |
Closed
added 2 commits
November 8, 2020 22:57
willhou
reviewed
Nov 9, 2020
willhou
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to automatically publish the fluent ui package on pub.dev whenever a new version is available. This will solve the problem where our flutter users weren't getting the latest icons. With this PR in , they will have always have the latest package.
We perform a dry-run whenever a PR is pushed which is basically creating the package and make sure nothing breaks on the branch. The actual publishing happens when the PR is merged into master.