chore(react-icons): Do not minimize build output and chunk icon files #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webpack builds a lot slower due when using running on large minified files. To fix this, the PR adds a `.babelrc` file with `compact: false` so the result is kept prettified (which is the default output of Typescript). Additionally, modified `convert.js` so that the output icons are chunked. This means that there will only be 500 icons per file. All contents of chunked files are exported from `index.ts`. This improves the build to ~1.5 minutes.
ling1726
added a commit
to ling1726/fluentui
that referenced
this pull request
Dec 6, 2021
tests icon changes from microsoft/fluentui-system-icons#373
2 tasks
|
addressed by acorjs in acornjs/acorn#1083 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack builds a lot slower due when using running on large minified
files. To fix this, the PR adds a
.babelrcfile withcompact: falseso the result is kept prettified (which is the default output of
Typescript).
Additionally, modified
convert.jsso that the output icons arechunked. This means that there will only be 500 icons per file. All
contents of chunked files are exported from
index.ts. This improvesthe build to ~1.5 minutes.