Code changes for our light-icon merge. #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willchavez
requested review from
nickromano,
praveen970,
MLoughry,
spencer-nelson and
tomi-msft
|
Will the Figma documentation be updated for these light/thin icons? |
@mdtauk Yes, the figma docs will be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prep for merging in the
light-iconsbranch into ourmainbranch, I've made some code changes related to building and publishing the light icons.I mainly focused on the
react,fonts, andreact-nativework. Please let me know if anything needs to be changed.