fix tabs class

microsoft · Feb 9, 2024 · 4138edc · 4138edc
1 parent 498cd17
commit 4138edc
Show file tree

Hide file tree

Showing 14 changed files with 356 additions and 369 deletions.
diff --git a/packages/web-components/docs/api-report.md b/packages/web-components/docs/api-report.md
@@ -5,7 +5,6 @@
 ```ts
 
 import type { Constructable } from '@microsoft/fast-element';
-import { CSSDesignToken } from '@microsoft/fast-foundation/design-token.js';
 import { Direction } from '@microsoft/fast-web-utilities';
 import { ElementStyles } from '@microsoft/fast-element';
 import { ElementViewTemplate } from '@microsoft/fast-element';
@@ -471,7 +470,7 @@ export class Button extends FormAssociatedButton {
     formnovalidate: boolean;
     // (undocumented)
     protected formnovalidateChanged(): void;
-    formtarget: "_self" | "_blank" | "_parent" | "_top";
+    formtarget: '_self' | '_blank' | '_parent' | '_top';
     // (undocumented)
     protected formtargetChanged(): void;
     iconOnly: boolean;
@@ -1653,45 +1652,12 @@ export const curveEasyEaseMax = "--curveEasyEaseMax";
 // @public (undocumented)
 export const curveLinear = "--curveLinear";
 
-// @public
-export class Dialog extends FASTElement {
-    ariaDescribedby?: string;
-    ariaLabelledby?: string;
-    connectedCallback(): void;
-    defaultTitleAction?: Button;
-    dialog: HTMLDialogElement;
-    disconnectedCallback(): void;
-    dismiss(): void;
-    handleClick(event: Event): boolean;
-    handleKeydown: (e: KeyboardEvent) => boolean | void;
-    hide(dismissed?: boolean): void;
-    // Warning: (ae-forgotten-export) The symbol "DialogModalType" needs to be exported by the entry point index.d.ts
-    modalType: DialogModalType;
-    modalTypeChanged(oldValue: DialogModalType, newValue: DialogModalType): void;
-    noTitleAction: boolean;
-    onOpenChangeEvent: (dismissed?: boolean) => void;
-    open: boolean;
-    openChanged(oldValue: boolean, newValue: boolean): void;
-    setComponent(): void;
-    show(): void;
-    titleAction: HTMLElement[];
-}
-
-// @public
-export const DialogDefinition: FASTElementDefinition<typeof Dialog>;
-
-// @public
-export const DialogStyles: ElementStyles;
-
-// @public
-export const DialogTemplate: ElementViewTemplate<Dialog>;
-
 // Warning: (ae-internal-mixed-release-tag) Mixed release tags are not allowed for "DelegatesARIAButton" because one of its declarations is marked as @internal
 //
 // @public
 export class DelegatesARIAButton {
-    ariaExpanded: "true" | "false" | string | null;
-    ariaPressed: "true" | "false" | "mixed" | string | null;
+    ariaExpanded: 'true' | 'false' | string | null;
+    ariaPressed: 'true' | 'false' | 'mixed' | string | null;
 }
 
 // Warning: (ae-forgotten-export) The symbol "ARIAGlobalStatesAndProperties" needs to be exported by the entry point index.d.ts
@@ -1704,7 +1670,7 @@ export interface DelegatesARIAButton extends ARIAGlobalStatesAndProperties {
 //
 // @public
 export class DelegatesARIALink {
-    ariaExpanded: "true" | "false" | string | null;
+    ariaExpanded: 'true' | 'false' | string | null;
 }
 
 // @internal
@@ -1787,7 +1753,10 @@ export const DividerDefinition: FASTElementDefinition<typeof Divider>;
 
 // @public
 export const DividerOrientation: {
-    readonly horizontal: "horizontal";
+    readonly horizontal: "horizontal"; /**
+    * Divider roles
+    * @public
+    */
     readonly vertical: "vertical";
 };
 
@@ -2009,37 +1978,6 @@ export class Menu extends FASTElement {
     toggleMenu: () => void;
 }
 
-// @public
-export class Menu extends FASTElement {
-    cleanup?: () => void;
-    closeMenu: () => void;
-    closeOnScroll?: boolean;
-    closeOnScrollChanged(oldValue: boolean, newValue: boolean): void;
-    connectedCallback(): void;
-    disconnectedCallback(): void;
-    focusMenuList(): void;
-    focusTrigger(): void;
-    handleMenuKeydown(e: KeyboardEvent): boolean | void;
-    handleTriggerKeydown: (e: KeyboardEvent) => boolean | void;
-    open: boolean;
-    openChanged(oldValue: boolean, newValue: boolean): void;
-    openMenu: (e?: Event) => void;
-    openOnContext?: boolean;
-    openOnContextChanged(oldValue: boolean, newValue: boolean): void;
-    openOnHover?: boolean;
-    openOnHoverChanged(oldValue: boolean, newValue: boolean): void;
-    persistOnItemClick?: boolean;
-    persistOnItemClickChanged(oldValue: boolean, newValue: boolean): void;
-    // @internal
-    positioningContainer?: HTMLElement;
-    setComponent(): void;
-    protected setPositioning(): void;
-    protected setPositioningTask: () => void;
-    slottedMenuList: MenuList[];
-    slottedTriggers: HTMLElement[];
-    toggleMenu: () => void;
-}
-
 // @public
 export class MenuButton extends Button {
 }
@@ -2271,7 +2209,7 @@ export class Radio extends FormAssociatedRadio implements RadioControl {
 }
 
 // @public (undocumented)
-export type RadioControl = Pick<HTMLInputElement, "checked" | "disabled" | "focus" | "setAttribute" | "getAttribute">;
+export type RadioControl = Pick<HTMLInputElement, 'checked' | 'disabled' | 'focus' | 'setAttribute' | 'getAttribute'>;
 
 // @public
 export const RadioDefinition: FASTElementDefinition<typeof Radio>;
@@ -2286,8 +2224,6 @@ export class RadioGroup extends FASTElement {
     connectedCallback(): void;
     disabled: boolean;
     // (undocumented)
-    protected disabledChanged(): void;
-    // (undocumented)
     disconnectedCallback(): void;
     // @internal (undocumented)
     focusOutHandler: (e: FocusEvent) => boolean | void;
@@ -2335,7 +2271,7 @@ export const RadioTemplate: ElementViewTemplate<Radio>;
 //
 // @internal (undocumented)
 export const roleForMenuItem: {
-    [value in keyof typeof MenuItemRole]: (typeof MenuItemRole)[value];
+    [value in keyof typeof MenuItemRole]: typeof MenuItemRole[value];
 };
 
 // @public

diff --git a/packages/web-components/src/accordion-item/accordion-item.ts b/packages/web-components/src/accordion-item/accordion-item.ts
@@ -134,5 +134,6 @@ export class AccordionItem extends FASTElement {
  * TODO: https://github.com/microsoft/fast/issues/3317
  * @internal
  */
-export type AccordionItem = StartEnd;
+/* eslint-disable-next-line @typescript-eslint/no-empty-interface */
+export interface AccordionItem extends StartEnd {}
 applyMixins(AccordionItem, StartEnd);
diff --git a/packages/web-components/src/anchor-button/anchor-button.ts b/packages/web-components/src/anchor-button/anchor-button.ts
@@ -239,7 +239,8 @@ export class DelegatesARIALink {
  * TODO: https://github.com/microsoft/fast/issues/3317
  * @internal
  */
-export type DelegatesARIALink = ARIAGlobalStatesAndProperties;
+/* eslint-disable-next-line @typescript-eslint/no-empty-interface */
+export interface DelegatesARIALink extends ARIAGlobalStatesAndProperties {}
 applyMixins(DelegatesARIALink, ARIAGlobalStatesAndProperties);
 
 /**
@@ -248,5 +249,6 @@ applyMixins(DelegatesARIALink, ARIAGlobalStatesAndProperties);
  * TODO: https://github.com/microsoft/fast/issues/3317
  * @internal
  */
+/* eslint-disable-next-line @typescript-eslint/no-empty-interface */
 export interface AnchorButton extends StartEnd, DelegatesARIALink {}
 applyMixins(AnchorButton, StartEnd, DelegatesARIALink);
diff --git a/packages/web-components/src/button/button.form-associated.ts b/packages/web-components/src/button/button.form-associated.ts
@@ -2,7 +2,8 @@ import { FASTElement } from '@microsoft/fast-element';
 import { FormAssociated } from '../form-associated/form-associated.js';
 
 class _Button extends FASTElement {}
-type _Button = FormAssociated;
+/* eslint-disable-next-line @typescript-eslint/no-empty-interface */
+interface _Button extends FormAssociated {}
 
 /**
  * @beta

diff --git a/packages/web-components/src/button/button.ts b/packages/web-components/src/button/button.ts
@@ -298,7 +298,8 @@ export class DelegatesARIAButton {
  * TODO: https://github.com/microsoft/fast/issues/3317
  * @internal
  */
-export type DelegatesARIAButton = ARIAGlobalStatesAndProperties;
+/* eslint-disable-next-line @typescript-eslint/no-empty-interface */
+export interface DelegatesARIAButton extends ARIAGlobalStatesAndProperties {}
 applyMixins(DelegatesARIAButton, ARIAGlobalStatesAndProperties);
 
 /**
@@ -307,5 +308,6 @@ applyMixins(DelegatesARIAButton, ARIAGlobalStatesAndProperties);
  * TODO: https://github.com/microsoft/fast/issues/3317
  * @internal
  */
+/* eslint-disable-next-line @typescript-eslint/no-empty-interface */
 export interface Button extends StartEnd, DelegatesARIAButton {}
 applyMixins(Button, StartEnd, DelegatesARIAButton);
diff --git a/packages/web-components/src/checkbox/checkbox.form-associated.ts b/packages/web-components/src/checkbox/checkbox.form-associated.ts
@@ -2,7 +2,8 @@ import { FASTElement } from '@microsoft/fast-element';
 import { CheckableFormAssociated } from '../form-associated/form-associated.js';
 
 class _Checkbox extends FASTElement {}
-type _Checkbox = CheckableFormAssociated;
+/* eslint-disable-next-line @typescript-eslint/no-empty-interface */
+interface _Checkbox extends CheckableFormAssociated {}
 
 /**
  * @beta

diff --git a/packages/web-components/src/form-associated/form-associated.ts b/packages/web-components/src/form-associated/form-associated.ts
@@ -647,7 +647,8 @@ export function FormAssociated<T extends ConstructableFormAssociated>(BaseCtor:
  * @beta
  */
 export function CheckableFormAssociated<T extends ConstructableFormAssociated>(BaseCtor: T): T {
-  type C = FormAssociatedElement;
+  /* eslint-disable-next-line @typescript-eslint/no-empty-interface */
+  interface C extends FormAssociatedElement {}
   class C extends FormAssociated(BaseCtor) {}
   class D extends C {
     /**

diff --git a/packages/web-components/src/radio/radio.form-associated.ts b/packages/web-components/src/radio/radio.form-associated.ts
@@ -2,7 +2,8 @@ import { FASTElement } from '@microsoft/fast-element';
 import { CheckableFormAssociated } from '../form-associated/form-associated.js';
 
 class _Radio extends FASTElement {}
-type _Radio = CheckableFormAssociated;
+/* eslint-disable-next-line @typescript-eslint/no-empty-interface */
+interface _Radio extends CheckableFormAssociated {}
 
 /**
  * @beta

diff --git a/packages/web-components/src/slider/slider.form-associated.ts b/packages/web-components/src/slider/slider.form-associated.ts
@@ -2,7 +2,8 @@ import { FASTElement } from '@microsoft/fast-element';
 import { FormAssociated } from '../form-associated/form-associated.js';
 
 class _Slider extends FASTElement {}
-type _Slider = FormAssociated;
+/* eslint-disable-next-line @typescript-eslint/no-empty-interface */
+interface _Slider extends FormAssociated {}
 
 /**
  * @beta

diff --git a/packages/web-components/src/switch/switch.form-associated.ts b/packages/web-components/src/switch/switch.form-associated.ts
@@ -2,7 +2,8 @@ import { FASTElement } from '@microsoft/fast-element';
 import { CheckableFormAssociated } from '../form-associated/form-associated.js';
 
 class _Switch extends FASTElement {}
-type _Switch = CheckableFormAssociated;
+/* eslint-disable-next-line @typescript-eslint/no-empty-interface */
+interface _Switch extends CheckableFormAssociated {}
 
 /**
  * @beta

diff --git a/packages/web-components/src/tab/tab.ts b/packages/web-components/src/tab/tab.ts
@@ -40,5 +40,6 @@ export class Tab extends FASTElement {
   }
 }
 
-export type Tab = StartEnd;
+/* eslint-disable-next-line @typescript-eslint/no-empty-interface */
+export interface Tab extends StartEnd {}
 applyMixins(Tab, StartEnd);