Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create official CRA template for fluentui/react #16427

Closed
8 tasks done
Hotell opened this issue Jan 11, 2021 · 0 comments
Closed
8 tasks done

create official CRA template for fluentui/react #16427

Hotell opened this issue Jan 11, 2021 · 0 comments
Assignees
@Hotell
Labels
Type: Feature

Comments

@Hotell
Copy link
Contributor

Hotell commented Jan 11, 2021 •
edited

Our getting started guide uses CRA repo which needs to be cloned, which is not an ideal approach anymore as CRA support custom templates since v3.4.

Goal is to create custom CRA template within our monorepo and update docs accordingly

-git clone https://github.com/microsoft/create-react-app-uifabric.git my-app
+npx create-react-app --template @fluentui/cra my-app
cd my-app
yarn

Tasks
@ecraig12345 ecraig12345 assigned Hotell and unassigned layershifter Jan 12, 2021
@kubkon kubkon mentioned this issue Jan 13, 2021
Merged
2 tasks
@Hotell Hotell mentioned this issue Jan 13, 2021
Open
@kubkon kubkon mentioned this issue Jan 26, 2021
Merged
2 tasks
msft-fluent-ui-bot pushed a commit that referenced this issue Feb 2, 2021
docs(public-docsite): update getting started with CRA (#16629)
84ab12f 
#### Pull request checklist

- [x] Addresses an existing issue: Fixes partially #16427
- [ ] Include a change request file using `$ yarn change`

#### Description of changes

Update getting started section in the public-docsite to include updated step-by-step on how to boot up using our CRA template.
@Hotell Hotell closed this as completed Feb 3, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Hotell Hotell

Labels
Type: Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Hotell @ecraig12345 @layershifter @msft-fluent-ui-bot