Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): properly resolve configs for projects that use so… #18437

Merged
merged 2 commits into from
Jun 4, 2021
Merged

fix(eslint-plugin): properly resolve configs for projects that use so… #18437

merged 2 commits into from
Jun 4, 2021

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 3, 2021 •
edited
Loading

…lution kind of TS config

Pull request checklist

  • [ ] Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Before:

  • with current setup linting was not working in editors within /tools project
  • while debugging I found out our dynamic config provided invalid paths for file property (double slash etc)

After:

  • linting now works consistently within /tools project from CLI and Editor
  • files are properly normalized

Focus areas to test

(optional)

@Hotell
Copy link
Contributor Author

Hotell commented Jun 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Hotell Hotell marked this pull request as ready for review June 3, 2021 12:11
@Hotell Hotell requested a review from a team as a code owner June 3, 2021 12:11
@fabricteam
Copy link
Collaborator

fabricteam commented Jun 3, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 788 791 5000
BaseButton mount 894 873 5000
Breadcrumb mount 2587 2676 1000
ButtonNext mount 478 472 5000
Checkbox mount 1484 1498 5000
CheckboxBase mount 1253 1277 5000
ChoiceGroup mount 4638 4697 5000
ComboBox mount 929 982 1000
CommandBar mount 9951 10070 1000
ContextualMenu mount 5995 5975 1000
DefaultButton mount 1100 1133 5000
DetailsRow mount 3620 3775 5000
DetailsRowFast mount 3631 3721 5000
DetailsRowNoStyles mount 3455 3443 5000
Dialog mount 2121 2079 1000
DocumentCardTitle mount 139 133 1000
Dropdown mount 3179 3197 5000
FocusTrapZone mount 1769 1785 5000
FocusZone mount 1784 1730 5000
IconButton mount 1668 1690 5000
Label mount 339 326 5000
Layer mount 1737 1739 5000
Link mount 449 461 5000
MakeStyles mount 1786 1791 50000
MenuButton mount 1428 1403 5000
MessageBar mount 1962 1976 5000
Nav mount 3179 3142 1000
OverflowSet mount 996 992 5000
Panel mount 1364 2111 1000
Persona mount 812 784 1000
Pivot mount 1398 1357 1000
PrimaryButton mount 1279 1255 5000
Rating mount 7552 7577 5000
SearchBox mount 1346 1325 5000
Shimmer mount 2581 2515 5000
Slider mount 1933 1913 5000
SpinButton mount 4969 4858 5000
Spinner mount 420 394 5000
SplitButton mount 3140 3101 5000
Stack mount 498 471 5000
StackWithIntrinsicChildren mount 1535 1490 5000
StackWithTextChildren mount 4434 4366 5000
SwatchColorPicker mount 10056 9936 5000
Tabs mount 1392 1348 1000
TagPicker mount 2388 2307 5000
TeachingBubble mount 11699 11793 5000
Text mount 394 394 5000
TextField mount 1360 1345 5000
ThemeProvider mount 1153 1169 5000
ThemeProvider virtual-rerender 606 586 5000
ThemeProviderNext mount 7244 7146 5000
Toggle mount 772 784 5000
buttonNative mount 104 114 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 163 146 1.12:1
FlexMinimalPerf.default 303 270 1.12:1
DropdownManyItemsPerf.default 699 642 1.09:1
RefMinimalPerf.default 245 227 1.08:1
SegmentMinimalPerf.default 359 332 1.08:1
ButtonSlotsPerf.default 550 520 1.06:1
GridMinimalPerf.default 341 324 1.05:1
RadioGroupMinimalPerf.default 444 423 1.05:1
TextMinimalPerf.default 349 333 1.05:1
LayoutMinimalPerf.default 351 336 1.04:1
ReactionMinimalPerf.default 371 356 1.04:1
SkeletonMinimalPerf.default 357 342 1.04:1
DividerMinimalPerf.default 356 345 1.03:1
ImageMinimalPerf.default 359 347 1.03:1
ListMinimalPerf.default 493 479 1.03:1
IconMinimalPerf.default 605 585 1.03:1
TableMinimalPerf.default 394 383 1.03:1
TooltipMinimalPerf.default 976 948 1.03:1
TreeMinimalPerf.default 803 778 1.03:1
VideoMinimalPerf.default 615 598 1.03:1
ButtonOverridesMissPerf.default 1650 1611 1.02:1
DropdownMinimalPerf.default 3083 3008 1.02:1
HeaderSlotsPerf.default 737 726 1.02:1
ItemLayoutMinimalPerf.default 1252 1222 1.02:1
ListNestedPerf.default 551 541 1.02:1
AnimationMinimalPerf.default 401 398 1.01:1
AttachmentSlotsPerf.default 1108 1099 1.01:1
ChatWithPopoverPerf.default 349 344 1.01:1
DialogMinimalPerf.default 742 733 1.01:1
EmbedMinimalPerf.default 4083 4049 1.01:1
LabelMinimalPerf.default 384 380 1.01:1
SliderMinimalPerf.default 1537 1528 1.01:1
TableManyItemsPerf.default 1833 1815 1.01:1
TextAreaMinimalPerf.default 484 478 1.01:1
TreeWith60ListItems.default 177 176 1.01:1
CardMinimalPerf.default 528 529 1:1
CarouselMinimalPerf.default 452 450 1:1
ListWith60ListItems.default 607 609 1:1
MenuMinimalPerf.default 822 821 1:1
MenuButtonMinimalPerf.default 1548 1545 1:1
PopupMinimalPerf.default 558 558 1:1
ProviderMergeThemesPerf.default 1635 1630 1:1
BoxMinimalPerf.default 336 339 0.99:1
ButtonMinimalPerf.default 165 166 0.99:1
ChatDuplicateMessagesPerf.default 274 278 0.99:1
CheckboxMinimalPerf.default 2701 2718 0.99:1
DatepickerMinimalPerf.default 5255 5317 0.99:1
ListCommonPerf.default 595 603 0.99:1
ProviderMinimalPerf.default 956 963 0.99:1
SplitButtonMinimalPerf.default 3636 3664 0.99:1
StatusMinimalPerf.default 651 656 0.99:1
CustomToolbarPrototype.default 3717 3736 0.99:1
AvatarMinimalPerf.default 188 191 0.98:1
HeaderMinimalPerf.default 354 363 0.98:1
AlertMinimalPerf.default 256 265 0.97:1
ToolbarMinimalPerf.default 907 938 0.97:1
AccordionMinimalPerf.default 141 147 0.96:1
FormMinimalPerf.default 383 400 0.96:1
InputMinimalPerf.default 1219 1265 0.96:1
LoaderMinimalPerf.default 681 708 0.96:1
ChatMinimalPerf.default 573 603 0.95:1
RosterPerf.default 1113 1198 0.93:1
PortalMinimalPerf.default 172 186 0.92:1

@Hotell
Copy link
Contributor Author

Hotell commented Jun 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@size-auditor
Copy link

size-auditor bot commented Jun 3, 2021

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: e7d97fd

Possible causes

  • The baseline build e7d97fd is broken
  • The Size Auditor run for the baseline build e7d97fd was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@Hotell Hotell enabled auto-merge (squash) June 4, 2021 08:01
@Hotell Hotell merged commit f856cb3 into microsoft:master Jun 4, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/webpack-utilities@v8.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/test-utilities@v8.0.6 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/set-version@v8.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-window-provider@v2.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-theme@v9.0.0-alpha.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-shared-contexts@v9.0.0-alpha.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/utilities@v8.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/theme@v2.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/theme-samples@v8.1.19 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/style-utilities@v8.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/scheme-utilities@v8.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-utilities@v9.0.0-alpha.28 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-tooltip@v9.0.0-alpha.43 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-cards@v1.0.0-beta.103 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-button@v9.0.0-alpha.44 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-badge@v9.0.0-alpha.46 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-avatar@v9.0.0-alpha.45 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-accordion@v9.0.0-alpha.37 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/public-docsite@v8.2.21 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/public-docsite-setup@v0.3.5 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/public-docsite-resources@v8.1.21 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/monaco-editor@v1.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/merge-styles@v8.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/make-styles@v9.0.0-alpha.25 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/keyboard-key@v0.3.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/jest-serializer-merge-styles@v8.0.7 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/jest-serializer-make-styles@v9.0.0-alpha.17 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/foundation-legacy@v8.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/font-icons-mdl2@v8.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/example-data@v8.2.3 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/eslint-plugin@v1.3.1 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/dom-utilities@v2.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/date-time-utilities@v8.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/common-styles@v1.0.8 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/codemods@v8.1.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/babel-make-styles@v9.0.0-alpha.15 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/azure-themes@v8.1.19 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/api-docs@v8.1.19 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-toggle@v1.0.0-beta.105 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-tabs@v1.0.0-beta.107 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-slider@v1.0.0-beta.105 has been released which incorporates this pull request.:tada:

Handy links:

@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/react-examples@v8.27.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

Assignees

@miroslavstastny miroslavstastny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Hotell @fabricteam @msft-fluent-ui-bot @ecraig12345 @miroslavstastny