Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-card has dependencies on v8, blocks migration to new DX #19050

Closed
tringakrasniqi opened this issue Jul 21, 2021 · 0 comments · Fixed by #19036
Closed

react-card has dependencies on v8, blocks migration to new DX #19050

tringakrasniqi opened this issue Jul 21, 2021 · 0 comments · Fixed by #19036
Assignees
Labels

Comments

@tringakrasniqi
Copy link
Contributor

tringakrasniqi commented Jul 21, 2021

Actual behavior:

react-card has dependencies on v8 which are a blocking issue for migration to the new DX, PR: #19036 .

In particular, the hook useFocusRects(state.ref); is used on all the components that comes from a v8 depencency, @fluentui/utilities.

Also, tests.js config file uses setIconOptions that come from @fluentui/react/lib/Styling

// Suppress icon warnings.
setIconOptions({
  disableWarnings: true,
});

that results in this error:

 /home/tringakrasniqi/workspace/fluentui-master/packages/react/lib/Styling.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import './version';
                                                                                             ^^^^^^

    SyntaxError: Cannot use import statement outside a module

Expected behavior:

No dependencies on v8 and tests.

@tringakrasniqi tringakrasniqi added this to Backlog in CXE Prague - @microsoft/cxe-prg via automation Jul 21, 2021
CXE Prague - @microsoft/cxe-prg automation moved this from Backlog to Done Jul 21, 2021
msft-fluent-ui-bot pushed a commit that referenced this issue Jul 21, 2021
#### Pull request checklist

- [x] Addresses an existing issue: Fixes partially #18579, fixes #19050
- [ ] Include a change request file using `$ yarn change`

#### Description of changes

Migration to new DX for react-card
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Jul 21, 2021
@Hotell Hotell moved this from Done to Archive in CXE Prague - @microsoft/cxe-prg Aug 4, 2021
PeterDraex pushed a commit to PeterDraex/fluentui that referenced this issue Aug 6, 2021
#### Pull request checklist

- [x] Addresses an existing issue: Fixes partially microsoft#18579, fixes microsoft#19050
- [ ] Include a change request file using `$ yarn change`

#### Description of changes

Migration to new DX for react-card
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants