Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate v8/v9 eslint configs #22127

Closed
ecraig12345 opened this issue Mar 16, 2022 · 0 comments · Fixed by #22128
Closed

Separate v8/v9 eslint configs #22127

ecraig12345 opened this issue Mar 16, 2022 · 0 comments · Fixed by #22128
Assignees
Labels
Status: Fixed Fixed in some PR

Comments

@ecraig12345
Copy link
Member

The current eslint configs were made a couple years ago before the plan for v9 was finalized. Instead of having v8/v9 share a config, they should have separate configs.

What we have today:

  • react: most of the rules for v8/v9
  • react--legacy: extends react; the main difference is this config requires interfaces to be prefixed with I
  • node: rules for node-based packages
  • node--legacy: extends node but with I on interfaces
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Fixed Fixed in some PR
Projects
Development

Successfully merging a pull request may close this issue.

3 participants