Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: react-nav-preview 0.4.0 footer styling issue #31723

Closed
2 tasks done
techienickb opened this issue Jun 15, 2024 · 2 comments
Closed
2 tasks done

[Bug]: react-nav-preview 0.4.0 footer styling issue #31723

techienickb opened this issue Jun 15, 2024 · 2 comments
Assignees
Labels
Fluent UI react-components (v9) Resolution: Won't Fix Not going to fix an issue due to various factors

Comments

@techienickb
Copy link

Library

React Components / v9 (@fluentui/react-components)

System Info

System:
    OS: Windows 11 10.0.22631
    CPU: (12) x64 12th Gen Intel(R) Core(TM) i7-1265U
    Memory: 1.99 GB / 15.83 GB
  Browsers:
    Edge: Chromium (126.0.2592.56), ChromiumDev (127.0.2610.3)
    Internet Explorer: 11.0.22621.3527

Are you reporting Accessibility issue?

no

Reproduction

https://stackblitz.com/edit/kt5i1c?file=src%2Fexample.tsx

Bug Description

Actual Behaviour

Nav Footer padding is not set correctly, is currently 0

Footer nav item category isn't width: 100% either

Expected Behaviour

Padding should be

0 var(--spacingHorizontalXS) 0 var(--spacingHorizontalMNudge)

Width on item category should be 100%

To reproduce use the NavDrawerFooter and compare the style tags with NavDrawerBody

Compare the body and footer in the example on https://stackblitz.com/edit/kt5i1c?file=src%2Fexample.tsx

Logs

No response

Requested priority

Normal

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@miroslavstastny
Copy link
Member

image

FYI @mltejera

@mltejera
Copy link
Contributor

Hey thanks for submitting @techienickb!

We've since changed direction on the footer for the Nav in that we don't want to include any content in the footer area going forward. We no longer consider it a supported path, even if it is possible. Please feel free to contribute a fix or solve on the consumption end :-)

@mltejera mltejera added the Resolution: Won't Fix Not going to fix an issue due to various factors label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-components (v9) Resolution: Won't Fix Not going to fix an issue due to various factors
Projects
None yet
Development

No branches or pull requests

3 participants