-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sticky - this.root undefined #4073
Labels
Comments
warmsea
added a commit
to warmsea/office-ui-fabric-react
that referenced
this issue
Feb 24, 2018
Merged
2 tasks
ThomasMichon
pushed a commit
that referenced
this issue
Feb 27, 2018
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to Fabric React! |
chrismohr
pushed a commit
to chrismohr/office-ui-fabric-react
that referenced
this issue
Apr 17, 2018
* Fix microsoft#4073 * Add change file.
It looks like this issue has been answered/resolved. Closing this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug Report
Priorities and help requested (not applicable if asking question):
Are you willing to submit a PR to fix? No
Requested priority: High
Describe the issue:
Sticky component does not work due to this.root being undefined, resulting in failing various function calls. Believe this is due to PR #4016 changing 'this.refs.root' to 'this._root' for resolving refs but function calls still using 'this.root' instead of 'this._root'. Looks like there are some other occurrences in that PR of adding a prefix of _ in the name but not updating where the variable is used such as ColorPicker/ColorRectangle.tsx.
Actual behavior:
this.root is undefined
Expected behavior:
this.root to resolve to the correct ref
If applicable, please provide a codepen repro:
Using the ScrollablePane DetailsList Locked Header example:
https://codesandbox.io/s/62kpzv6l5n
The text was updated successfully, but these errors were encountered: