Text is required on Checkbox

[mike-morr]

The text field should be optional. If I get some time, I will submit a PR, but customers are keeping me busy.

I am doing <Checkbox text="" /> as workaround.

[mikewheaton]

Can you provide a screenshot to show where you're using a checkbox without a label?

[mike-morr]

Like that with better alignment..

[cschlechty]

Rather than having no text, should we allow passing a label equivalent
instead so we can assure these controls are associated correctly?

On Tue, Aug 2, 2016 at 3:29 PM, Mike Morrison notifications@github.com
wrote:

[image: image]
https://cloud.githubusercontent.com/assets/6625993/17347472/b8e67264-58d5-11e6-868d-eb18d3c08d3d.png

Like that with better alignment..

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#47 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATa0j0tn5XJnSdLeSgxO9zYCwgir1sQIks5qb8TDgaJpZM4Ja9yX
.

[mikewheaton]

@cschlechty: That's my concern as well. If no label is provided, how do we make sure that whatever control is used (in this case, a text field) is associated correctly with the input?

What we're seeing for "Print images" is the ability to edit the text of a task? Or create a new one? It's not clear how to get into that state or commit the change.

[mike-morr]

It is trying to mimic the todomvc examples. With this, double clicking a checkbox label, should change the label into a edit box with the current value. Hitting enter should commit the change. I just noticed there is a todo example in the source of this project, so I am going to check that out.

[dzearing]

I believe this has been resolved. There is no text property; only an optional label.