Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Component: Editable Table #6840

Closed
11 tasks
micahgodbolt opened this issue Oct 24, 2018 · 12 comments
Closed
11 tasks

New Component: Editable Table #6840

micahgodbolt opened this issue Oct 24, 2018 · 12 comments
Labels
Status: Not on Roadmap Issue is not currently on roadmap, no fix planned Type: Feature
Milestone

Comments

@micahgodbolt
Copy link
Member

micahgodbolt commented Oct 24, 2018

Component Details

A component for laying our rows of table'like data. In the past devs often reached for DetailsList when all they wanted was to display rows of data/form elements. A Table, TableList, GridList (whatever) component would be a lighter weight list view without all the row selection functionality.

It's possible that this could become an abstraction for the details list, moving all of the core layout logic into it, and leaving the selection/custom logic into the details list itself.

Imports

List

Exports/ Component Breakdown

Table

Intended Package

OUFR

Code mockup/example

image

Code Sample


Types

Name Type Default Value Description
className string Optional class name to be added to the root

Design Assets

Component Ownership

Core Tactical component

Deadlines

Steps

  • Themable (Component.base/Component.styles)
  • Unit tests
  • Visual tests
  • Documentation and examples
  • Keyboard Accessible
  • High Constrast Support
  • RTL Support
  • Design Review
  • API review
  • Public Preview
  • Ready for Publishing
@KevinTCoughlin
Copy link
Member

KevinTCoughlin commented Oct 24, 2018

We've had a few folks ask for editable cell support [#5329]. Do you think that would align well with this new component or should we consider that out-of-scope for now?

@micahgodbolt
Copy link
Member Author

not sure if they are the same thing, but editable cells could be built off of this

@micahgodbolt
Copy link
Member Author

interesting thought here....how do we define each row of data in this table? It's basically a bunch of forms stacked on top of each other right? Could this table be defined as an array of Form elements, and could this be a good opportunity to look at #5582 and define each row via a JSON schema, rather than a specific JSX element? i.e. a column could be a hex value selected via a textfield today, and tomorrow switch to a color picker. That should be as adding a 'color' format'.

{
  "title": "Person",
  "type": "object",
  "required": [
    "name",
    "age",
    "date",
  ],
  "properties": {
    "name": {
      "type": "string",
      "description": "First and Last name",
      "minLength": 4
    },
    "age": {
      "type": "integer",
      "default": 25,
      "minimum": 18,
      "maximum": 99
    },
    "favorite_color": {
      "type": "string",
      "format": "color",
      "title": "favorite color",
      "default": "#ffa500"
    }
  }
}

@micahgodbolt micahgodbolt changed the title New Component: Table New Component: Editable Table Dec 14, 2018
@dzearing dzearing modified the milestones: Fabric Backlog, Backlog Jan 11, 2019
@micahgodbolt micahgodbolt removed this from the Backlog milestone Jan 11, 2019
@dzearing dzearing modified the milestone: Backlog Jan 11, 2019
@micahgodbolt micahgodbolt added this to the Backlog milestone Jan 11, 2019
@lukasbash
Copy link

lukasbash commented May 22, 2019

Quick question when reading this:

A component for laying our rows of table'like data. [...]

... and reading the current status and progress on this issue (as far as I can see, something between backlog and proposal 😄 ) I wanted to ask if it makes sense to split up the issue to first, get a table component without editable features to get it done earlier, and a second one to put in the editable stuff?

I am currently using the DetailsList component with some custom implementations (also some that you might not consider as worth to be standardized).

Cheers

@daxamin
Copy link

daxamin commented Oct 18, 2019

Any updates on this feature?

@micahgodbolt
Copy link
Member Author

not on our radar at the moment for core controls

@DesignPolice
Copy link

@micahgodbolt, hello there, we have a new product that could use this feature… looks like this has stalled out a bit, but just wanted to verify if it was continuing be a backlog item or if there was something that might be coming out. Thanks

@kwiremo
Copy link

kwiremo commented Apr 10, 2020

Is this still on your radar?

@micahgodbolt
Copy link
Member Author

Probably won't be a core control (at least for a while). Would be a good candidate for a partner team to build/own/share.

@DesignPolice
Copy link

Thanks @micahgodbolt

I will touchbase with our team and see if this some lifting we can help with - I know we are needing it in a few spots. Thanks for the update.

@mareekuh
Copy link

@DesignPolice - The above looks like a table. What about a list? The file-open/save type list view with the ability to rename/add?

@JustSlone JustSlone added the Status: Not on Roadmap Issue is not currently on roadmap, no fix planned label Mar 3, 2021
@JustSlone
Copy link
Collaborator

JustSlone commented Mar 3, 2021

Out of scope for the foreseeable future, closing out

@microsoft microsoft locked as resolved and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Not on Roadmap Issue is not currently on roadmap, no fix planned Type: Feature
Projects
None yet
Development

No branches or pull requests