Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContextualMenu: revert fluent update #10005

Merged
merged 3 commits into from Jul 31, 2019
Merged

ContextualMenu: revert fluent update #10005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9629532
Reverted splitPrimary button hover back to highlighting entire button
mahendrareddyMSFT Jul 30, 2019
fdbeb24
Merge branch '6.0' into v-mare/ContextualMenu-revert-fluent-update
mahendrareddyMSFT Jul 31, 2019
ecc7b64
Change files
mahendrareddyMSFT Jul 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...uifabric-fluent-theme-2019-07-31-11-21-56-v-mare-ContextualMenu-revert-fluent-update.json
View file
Open in desktop
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "ContextualMenu: Reverts splitPrimary button hover state back to highlighting whole button",
"packageName": "@uifabric/fluent-theme",
"email": "v-mare@microsoft.com",
"commit": "fdbeb24dc9ba95c0a99f8fc5834cf0c7ca7d3eb8",
"date": "2019-07-31T18:21:56.836Z"
}
7 changes: 1 addition & 6 deletions packages/fluent-theme/src/fluent/styles/ContextualMenu.styles.ts
View file
Open in desktop
Expand Up @@ -84,12 +84,7 @@ export const ContextualMenuStyles = (props: IContextualMenuStyleProps): Partial<
lineHeight: CONTEXTUAL_MENU_ITEM_HEIGHT,
selectors: {
':hover': {
backgroundColor: palette.neutralLighter,
selectors: {
'~$splitMenu': {
backgroundColor: palette.white
}
}
backgroundColor: palette.neutralLighter
}
}
},
Expand Down