Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Safari default input outline #12279

Merged
merged 4 commits into from
Mar 24, 2020
Merged

Hide Safari default input outline #12279

merged 4 commits into from
Mar 24, 2020

Conversation

sheff146
Copy link
Contributor

@sheff146 sheff146 commented Mar 12, 2020 •
edited

Pull request checklist

Description of changes

Disabled default input outline

Focus areas to test

Visual testing of inputs

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Mar 12, 2020
@size-auditor
Copy link

size-auditor bot commented Mar 12, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ed9b0595c59ad1f1fe340c1f533d55214452cb63 (build)

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Mar 12, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 973 881
BaseButton (experiments) 1128 1095
DefaultButton 1177 1169
DefaultButton (experiments) 2110 2103
DetailsRow 3657 3688
DetailsRow (fast icons) 3571 3726
DetailsRow without styles 3487 3440
DocumentCardTitle with truncation 1599 1681
MenuButton 1561 1612
MenuButton (experiments) 3815 3798
PrimaryButton 1288 1410
PrimaryButton (experiments) 2161 2131
SplitButton 3229 3356
SplitButton (experiments) 7409 7525
Stack 498 500
Stack with Intrinsic children 1161 1222
Stack with Text children 4585 4719
Text 399 408
Toggle 968 1021
Toggle (experiments) 2391 2355
button 73 76

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.6 0.53 1.13:1 2000 1206
🦄 Button.Fluent 0.12 0.21 0.57:1 5000 588
🔧 Checkbox.Fluent 0.81 0.46 1.76:1 1000 813
🔧 Dialog.Fluent 0.46 0.22 2.09:1 5000 2294
🔧 Dropdown.Fluent 4.05 0.55 7.36:1 1000 4054
🔧 Icon.Fluent 0.2 0.06 3.33:1 5000 991
🎯 Image.Fluent 0.1 0.12 0.83:1 5000 482
🔧 Slider.Fluent 1.72 0.49 3.51:1 1000 1719
🔧 Text.Fluent 0.09 0.02 4.5:1 5000 463
🦄 Tooltip.Fluent 0.14 19.81 0.01:1 5000 699

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ImageMinimalPerf.default 474 371 1.28:1
GridMinimalPerf.default 1109 1006 1.1:1
HeaderSlotsPerf.default 2203 2002 1.1:1
RefMinimalPerf.default 232 211 1.1:1
Image.Fluent 482 440 1.1:1
CardMinimalPerf.default 477 445 1.07:1
BoxMinimalPerf.default 443 418 1.06:1
DividerMinimalPerf.default 1203 1139 1.06:1
ListNestedPerf.default 1167 1096 1.06:1
Button.Fluent 588 557 1.06:1
InputMinimalPerf.default 1268 1204 1.05:1
ListCommonPerf.default 1263 1202 1.05:1
StatusMinimalPerf.default 801 765 1.05:1
VideoMinimalPerf.default 1109 1059 1.05:1
Avatar.Fluent 1206 1153 1.05:1
AnimationMinimalPerf.default 790 757 1.04:1
FormMinimalPerf.default 1181 1134 1.04:1
MenuButtonMinimalPerf.default 1945 1876 1.04:1
Checkbox.Fluent 813 782 1.04:1
Dropdown.Fluent 4054 3902 1.04:1
Icon.Fluent 991 955 1.04:1
AvatarMinimalPerf.default 654 635 1.03:1
ButtonSlotsPerf.default 703 684 1.03:1
ChatDuplicateMessagesPerf.default 537 523 1.03:1
LabelMinimalPerf.default 473 460 1.03:1
TextMinimalPerf.default 479 464 1.03:1
TextAreaMinimalPerf.default 3697 3586 1.03:1
FlexMinimalPerf.default 333 326 1.02:1
ProviderMergeThemesPerf.default 1615 1584 1.02:1
TooltipMinimalPerf.default 1021 1001 1.02:1
Dialog.Fluent 2294 2253 1.02:1
AttachmentSlotsPerf.default 4155 4099 1.01:1
ButtonMinimalPerf.default 175 174 1.01:1
ListWith60ListItems.default 1398 1380 1.01:1
RadioGroupMinimalPerf.default 673 669 1.01:1
CustomToolbarPrototype.default 4156 4129 1.01:1
Slider.Fluent 1719 1698 1.01:1
AccordionMinimalPerf.default 294 295 1:1
HeaderMinimalPerf.default 678 680 1:1
LayoutMinimalPerf.default 811 811 1:1
PortalMinimalPerf.default 367 366 1:1
SliderMinimalPerf.default 1744 1738 1:1
AlertMinimalPerf.default 724 733 0.99:1
ChatMinimalPerf.default 683 692 0.99:1
EmbedMinimalPerf.default 6147 6199 0.99:1
IconMinimalPerf.default 501 506 0.99:1
ItemLayoutMinimalPerf.default 2534 2558 0.99:1
LoaderMinimalPerf.default 1190 1203 0.99:1
PopupMinimalPerf.default 266 269 0.99:1
TableMinimalPerf.default 804 811 0.99:1
Text.Fluent 463 469 0.99:1
CheckboxMinimalPerf.default 3584 3673 0.98:1
DialogMinimalPerf.default 2240 2286 0.98:1
DropdownMinimalPerf.default 4000 4061 0.98:1
CarouselMinimalPerf.default 2216 2294 0.97:1
ReactionMinimalPerf.default 2830 2916 0.97:1
SplitButtonMinimalPerf.default 13828 14241 0.97:1
TreeMinimalPerf.default 1429 1466 0.97:1
TreeWith60ListItems.default 279 288 0.97:1
Tooltip.Fluent 699 719 0.97:1
AttachmentMinimalPerf.default 983 1024 0.96:1
DropdownManyItemsPerf.default 1615 1681 0.96:1
ProviderMinimalPerf.default 725 759 0.96:1
ToolbarMinimalPerf.default 1343 1403 0.96:1
MenuMinimalPerf.default 2345 2456 0.95:1
SegmentMinimalPerf.default 1278 1363 0.94:1
HierarchicalTreeMinimalPerf.default 1199 1293 0.93:1
ListMinimalPerf.default 527 567 0.93:1
ChatWithPopoverPerf.default 662 724 0.91:1

@sheff146 sheff146 marked this pull request as ready for review March 24, 2020 10:44
@jurokapsiar jurokapsiar merged commit 49290e1 into microsoft:master Mar 24, 2020
DuanShaolong pushed a commit to DuanShaolong/fluentui that referenced this pull request Apr 27, 2020
@sheff146 @jurokapsiar @DuanShaolong
Hide Safari default input outline (microsoft#12279)
019f594 
* Fix default Safari outline

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Juraj Kapsiar <jurokapsiar@gmail.com>
This was referenced Sep 5, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneeshack4 aneeshack4 aneeshack4 approved these changes

@jurokapsiar jurokapsiar jurokapsiar approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@JasonGore JasonGore Awaiting requested review from JasonGore

@jdhuntington jdhuntington Awaiting requested review from jdhuntington

@layershifter layershifter Awaiting requested review from layershifter

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@mnajdova mnajdova Awaiting requested review from mnajdova

@pompomon pompomon Awaiting requested review from pompomon

@silviuaavram silviuaavram Awaiting requested review from silviuaavram

Assignees

@aneeshack4 aneeshack4

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Safari: Wrong focus indicator on Input
4 participants
@sheff146 @msft-github-bot @aneeshack4 @jurokapsiar