fix(Toolbar): fix positioning for overflow ToolbarMenu #12390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
JasonGore,
jdhuntington,
jurokapsiar,
levithomason,
miroslavstastny,
mnajdova,
pompomon and
silviuaavram
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
layershifter
changed the title
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
miroslavstastny
approved these changes
Mar 23, 2020
|
|
||
| React.useLayoutEffect(() => { | ||
| if (node) { | ||
| node.contentDocument.documentElement.style.fontSize = '14px'; |
There was a problem hiding this comment.
nit: I would also set a background to make the frame obvious.
miroslavstastny
pushed a commit
that referenced
this pull request
Apr 15, 2020
* fix(Toolbar): fix positioning for overflow ToolbarItem * add border * add RTL sample * add changelog entry * update entry * update steps * update steps * update steps * update steps * add duplicate for RTL * one more update (cherry picked from commit 3ad8d6c)
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
* fix(Toolbar): fix positioning for overflow ToolbarItem * add border * add RTL sample * add changelog entry * update entry * update steps * update steps * update steps * update steps * add duplicate for RTL * one more update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR fixes positioning for
ToolbarMenuinoverflowIteminsideToolbar. Adds a screener tests to avoid regressions.Microsoft Reviewers: Open in CodeFlow