feat(Dropdown): support disabled items #12407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
dzearing,
JasonGore,
jdhuntington,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
| if ( | ||
| !_.isNil(highlightedIndex) && | ||
| this.state.filteredItems.length && | ||
| !this.props.items[highlightedIndex]['disabled'] |
There was a problem hiding this comment.
It will not work with old render callback, but it's already deprecated:
const items = [render => render("foo")];
layershifter
approved these changes
Mar 25, 2020
| @@ -867,6 +867,7 @@ class Dropdown extends AutoControlledComponent<WithAsProp<DropdownProps>, Dropdo | |||
| ...getItemProps({ | |||
| item, | |||
| index, | |||
| disabled: !!item['disabled'], | |||
There was a problem hiding this comment.
Suggested change
| disabled: !!item['disabled'], | |
| disabled: item['disabled'], |
Is it really required?
There was a problem hiding this comment.
double checked in downshift and it's not. will remove, thanks!
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
* add disabled prop to DropdownItem * use disabled prop in downshift getItemProps * prevent selection by Tab on disabled items * add unit tests * use item directly in function * changelog * remove boolean conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Downshift already supports handling
disabledas a key in the item object. We need to pass that from ourDropdowntogetItemPropsin order to make it work.Fully functional disabled item navigation should be achievable by updating to Downshift https://github.com/downshift-js/downshift/releases/tag/v4.0.1 or above.
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow