fix(playground): fix Loader page & improve Card's playground #12417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
JasonGore,
jdhuntington,
jurokapsiar,
levithomason,
miroslavstastny,
mnajdova,
pompomon and
silviuaavram
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
mnajdova
reviewed
Mar 25, 2020
| @@ -20,12 +20,15 @@ import CardFooter from './CardFooter'; | |||
| import CardTopControls from './CardTopControls'; | |||
| import CardColumn from './CardColumn'; | |||
|
|
|||
| export interface CardProps extends UIComponentProps, ChildrenComponentProps { | |||
| export interface CardProps extends UIComponentProps { | |||
There was a problem hiding this comment.
Suggested change
| export interface CardProps extends UIComponentProps { | |
| export interface CardProps extends UIComponentProps, ChildrenComponentProps<React.ReactNode> { |
mnajdova
approved these changes
Mar 25, 2020
…com/OfficeDev/office-ui-fabric-react into fix/playground-props � Conflicts: � packages/fluentui/CHANGELOG.md
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
…ft#12417) * fix(playground): fix Loader page & improve Card's playground * add changelog entry * update changelog
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR:
Loaderdocumentation page:Cardcomponent:Microsoft Reviewers: Open in CodeFlow