Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:(ButtonContent): className and added conformat test #12431

Merged
merged 4 commits into from
Mar 26, 2020
Merged

fix:(ButtonContent): className and added conformat test #12431

merged 4 commits into from
Mar 26, 2020

Conversation

mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Mar 26, 2020 •
edited by msft-github-bot

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Mar 26, 2020
@mnajdova mnajdova changed the title fix:(ButtonContent): className and added conformant test fix:(ButtonContent): className Mar 26, 2020
@mnajdova mnajdova changed the title fix:(ButtonContent): className fix:(ButtonContent): className and added conformat test Mar 26, 2020
@msft-github-bot
Copy link
Contributor

msft-github-bot commented Mar 26, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Status
BaseButton 914 861
BaseButton (experiments) 998 1019
DefaultButton 1103 1114
DefaultButton (experiments) 1926 1946
DetailsRow 3411 3447
DetailsRow (fast icons) 3653 3523
DetailsRow without styles 3249 3213
DocumentCardTitle with truncation 1549 1525
MenuButton 1450 1465
MenuButton (experiments) 3568 3566
PrimaryButton 1268 1248
PrimaryButton (experiments) 2036 2001
SplitButton 3103 3107
SplitButton (experiments) 6993 6970
Stack 463 488
Stack with Intrinsic children 1095 1104
Stack with Text children 4256 4216
Text 389 390
Toggle 922 914
Toggle (experiments) 2240 2243
button 72 70

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.57 0.51 1.12:1 2000 1142
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 551
🔧 Checkbox.Fluent 0.77 0.42 1.83:1 1000 766
🔧 Dialog.Fluent 0.42 0.21 2:1 5000 2124
🔧 Dropdown.Fluent 3.75 0.51 7.35:1 1000 3750
🔧 Icon.Fluent 0.19 0.05 3.8:1 5000 935
🎯 Image.Fluent 0.08 0.11 0.73:1 5000 419
🔧 Slider.Fluent 1.63 0.45 3.62:1 1000 1627
🔧 Text.Fluent 0.09 0.02 4.5:1 5000 456
🦄 Tooltip.Fluent 0.14 18.8 0.01:1 5000 689

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 171 155 1.1:1
FlexMinimalPerf.default 319 296 1.08:1
ListNestedPerf.default 1106 1021 1.08:1
ButtonSlotsPerf.default 694 650 1.07:1
ChatDuplicateMessagesPerf.default 475 444 1.07:1
HeaderSlotsPerf.default 2001 1869 1.07:1
LabelMinimalPerf.default 459 428 1.07:1
Image.Fluent 419 391 1.07:1
AlertMinimalPerf.default 680 640 1.06:1
RadioGroupMinimalPerf.default 671 633 1.06:1
Tooltip.Fluent 689 652 1.06:1
CardMinimalPerf.default 449 427 1.05:1
LayoutMinimalPerf.default 793 753 1.05:1
PopupMinimalPerf.default 260 248 1.05:1
TableMinimalPerf.default 799 761 1.05:1
Button.Fluent 551 525 1.05:1
DialogMinimalPerf.default 2195 2112 1.04:1
MenuButtonMinimalPerf.default 1753 1686 1.04:1
Text.Fluent 456 439 1.04:1
DropdownMinimalPerf.default 3882 3757 1.03:1
HierarchicalTreeMinimalPerf.default 1205 1168 1.03:1
ListWith60ListItems.default 1338 1305 1.03:1
MenuMinimalPerf.default 2222 2163 1.03:1
ProviderMinimalPerf.default 690 669 1.03:1
AttachmentSlotsPerf.default 3820 3757 1.02:1
LoaderMinimalPerf.default 1106 1089 1.02:1
PortalMinimalPerf.default 335 328 1.02:1
ProviderMergeThemesPerf.default 1450 1424 1.02:1
StatusMinimalPerf.default 742 731 1.02:1
TooltipMinimalPerf.default 938 918 1.02:1
Slider.Fluent 1627 1602 1.02:1
ChatMinimalPerf.default 665 656 1.01:1
DropdownManyItemsPerf.default 1613 1600 1.01:1
FormMinimalPerf.default 1101 1085 1.01:1
TextAreaMinimalPerf.default 3373 3345 1.01:1
TreeMinimalPerf.default 1368 1348 1.01:1
AccordionMinimalPerf.default 277 278 1:1
AnimationMinimalPerf.default 736 735 1:1
BoxMinimalPerf.default 406 407 1:1
ChatWithPopoverPerf.default 661 664 1:1
CheckboxMinimalPerf.default 3448 3449 1:1
ImageMinimalPerf.default 414 416 1:1
InputMinimalPerf.default 1095 1098 1:1
ReactionMinimalPerf.default 2670 2673 1:1
SplitButtonMinimalPerf.default 12937 12906 1:1
Avatar.Fluent 1142 1137 1:1
Checkbox.Fluent 766 765 1:1
Dropdown.Fluent 3750 3743 1:1
DividerMinimalPerf.default 1111 1125 0.99:1
EmbedMinimalPerf.default 5711 5789 0.99:1
GridMinimalPerf.default 969 975 0.99:1
HeaderMinimalPerf.default 623 628 0.99:1
IconMinimalPerf.default 479 482 0.99:1
RefMinimalPerf.default 208 210 0.99:1
SegmentMinimalPerf.default 1256 1265 0.99:1
SliderMinimalPerf.default 1575 1591 0.99:1
CustomToolbarPrototype.default 3789 3838 0.99:1
Dialog.Fluent 2124 2142 0.99:1
AttachmentMinimalPerf.default 961 980 0.98:1
CarouselMinimalPerf.default 2138 2176 0.98:1
TextMinimalPerf.default 444 455 0.98:1
AvatarMinimalPerf.default 591 612 0.97:1
ToolbarMinimalPerf.default 1249 1288 0.97:1
TreeWith60ListItems.default 239 248 0.96:1
VideoMinimalPerf.default 1007 1046 0.96:1
Icon.Fluent 935 971 0.96:1
ListCommonPerf.default 1089 1141 0.95:1
ListMinimalPerf.default 488 511 0.95:1
ItemLayoutMinimalPerf.default 2239 2370 0.94:1

@mnajdova mnajdova closed this Mar 26, 2020
@mnajdova mnajdova reopened this Mar 26, 2020
@mnajdova mnajdova merged commit 41cf23c into microsoft:master Mar 26, 2020
DuanShaolong pushed a commit to DuanShaolong/fluentui that referenced this pull request Apr 27, 2020
@mnajdova @DuanShaolong
fix:(ButtonContent): className and added conformat test (microsoft#12431
47a9361 
)

* -fixed button content classname and added conformant test

* -added changelog entry

* -removed test

* -added test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@pompomon pompomon Awaiting requested review from pompomon

@silviuaavram silviuaavram Awaiting requested review from silviuaavram

Assignees

@aneeshack4 aneeshack4

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnajdova @msft-github-bot @layershifter @aneeshack4