chore(jest): add typeahead for watch mode #12467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 16345e00d8e3ff4071793da22ee52b5a8e49ccb3 (build) |
kolaps33
approved these changes
Mar 30, 2020
pompomon
approved these changes
Mar 31, 2020
| @@ -12,4 +12,5 @@ module.exports = { | |||
| 'test/(.*)$': `<rootDir>/test/$1`, | |||
| }, | |||
| setupFilesAfterEnv: [...commonConfig.setupFilesAfterEnv, './test/setup.ts'], | |||
| watchPlugins: ['jest-watch-typeahead/filename', 'jest-watch-typeahead/testname'], | |||
There was a problem hiding this comment.
Please move this to shared config
miroslavstastny
approved these changes
Mar 31, 2020
dzearing
reviewed
Mar 31, 2020
| @@ -38,6 +38,7 @@ | |||
| "@types/simulant": "^0.2.0", | |||
| "@uifabric/build": "^7.0.0", | |||
| "faker": "^4.1.0", | |||
| "jest-watch-typeahead": "^0.4.2", | |||
There was a problem hiding this comment.
@kenotron or @ecraig12345 should this just go in the scripts/package.json file?
|
It'd be great if we could add to I'd love for there to be one standard config really, but that might be outside the scope here. |
|
Yes, standardizing on one config is definitely out of scope for this PR. |
|
@ecraig12345 @dzearing I pushed latest change, moved the devDependency to the scripts/package.json. |
dzearing
approved these changes
Apr 3, 2020
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
* add package and configure jest * add watch plugin to main jest config * move devDepend to scripts package.json * add to watchPlugins to jest-resources as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Adds https://github.com/jest-community/jest-watch-typeahead to our jest config.
You now have autocomplete/typeahead functionality when you use filtering by file name or by test name in your
yarn test:watch.Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow