Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fabric=>fluent wording updates #12508

Merged
merged 17 commits into from Apr 10, 2020
Merged

More fabric=>fluent wording updates #12508

merged 17 commits into from Apr 10, 2020

Conversation

ecraig12345
Copy link
Member

@ecraig12345 ecraig12345 commented Apr 1, 2020 •
edited by msft-github-bot

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

Even more Fabric=>Fluent updates (outside the website):

  • "Office UI Fabric React" and variants to "Fluent UI React" almost everywhere, with a note in each readme "(formerly Office UI Fabric React)" linking to the blog post
  • "Office" and "Office 365" to "Microsoft 365"
  • developer.microsoft.com/fabric (and variants) to developer.microsoft.com/en-us/fluentui
  • Update example code in readmes to import from @fluentui/react

Extra updates in certain packages:

  • office-ui-fabric-react: add note about the rename, link to blog post, and instructions for migrating
  • example-app-base: add note that the components are deprecated and we recommend Storybook instead
  • experiments, react-cards: remove details about experimental component graduation since the plan for that may change
  • file-type-icons: remove section about how to use the fluent file type icons which is presumably irrelevant now
Microsoft Reviewers: Open in CodeFlow

@size-auditor
Copy link

size-auditor bot commented Apr 2, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 030cf5bdc02f32cdc4b0549836d0c17aa3ee3772 (build)

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Apr 2, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 860 875 5000
Checkbox 1950 1872 5000
CheckboxBase 1547 1551 5000
ChoiceGroup 5610 5533 5000
ComboBox 999 952 1000
CommandBar 7419 7366 1000
DefaultButton 1133 1117 5000
DetailsRow 3495 3449 5000
DetailsRow (fast icons) 3464 3498 5000
DetailsRow without styles 3331 3258 5000
Dialog 1516 1535 1000
DocumentCardTitle with truncation 1558 1565 1000
Dropdown 3053 3028 5000
FocusZone 1625 1674 5000
IconButton 1773 1755 5000
Label 538 548 5000
Link 471 465 5000
MenuButton 1449 1464 5000
Nav 3230 3227 1000
Panel 1725 1722 1000
Persona 856 865 1000
Pivot 1316 1372 1000
PrimaryButton 1243 1254 5000
SearchBox 1583 1498 5000
Slider 1889 1859 5000
Spinner 380 389 5000
SplitButton 3112 3104 5000
Stack 472 469 5000
Stack with Intrinsic children 1096 1127 5000
Stack with Text children 4341 4268 5000
TagPicker 2799 2751 5000
Text 383 402 5000
TextField 1758 1753 5000
Toggle 883 896 5000
button 67 68 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.59 0.51 1.16:1 2000 1184
🦄 Button.Fluent 0.11 0.2 0.55:1 5000 569
🔧 Checkbox.Fluent 0.77 0.4 1.93:1 1000 770
🔧 Dialog.Fluent 0.43 0.21 2.05:1 5000 2143
🔧 Dropdown.Fluent 3.98 0.51 7.8:1 1000 3978
🔧 Icon.Fluent 0.15 0.05 3:1 5000 748
🎯 Image.Fluent 0.09 0.11 0.82:1 5000 438
🔧 Slider.Fluent 1.62 0.43 3.77:1 1000 1620
🔧 Text.Fluent 0.08 0.02 4:1 5000 385
🦄 Tooltip.Fluent 0.13 16.97 0.01:1 5000 644

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 224 196 1.14:1
CardMinimalPerf.default 481 434 1.11:1
ListCommonPerf.default 1235 1128 1.09:1
IconMinimalPerf.default 774 711 1.09:1
AttachmentMinimalPerf.default 171 159 1.08:1
Image.Fluent 438 407 1.08:1
GridMinimalPerf.default 989 936 1.06:1
RadioGroupMinimalPerf.default 636 598 1.06:1
ListMinimalPerf.default 546 519 1.05:1
PopupMinimalPerf.default 252 239 1.05:1
ImageMinimalPerf.default 424 407 1.04:1
SliderMinimalPerf.default 1616 1559 1.04:1
Avatar.Fluent 1184 1138 1.04:1
AvatarMinimalPerf.default 646 628 1.03:1
BoxMinimalPerf.default 381 369 1.03:1
ChatMinimalPerf.default 710 686 1.03:1
DialogMinimalPerf.default 2124 2064 1.03:1
FormMinimalPerf.default 1091 1057 1.03:1
HierarchicalTreeMinimalPerf.default 1204 1169 1.03:1
InputMinimalPerf.default 1152 1116 1.03:1
SplitButtonMinimalPerf.default 3996 3883 1.03:1
TreeWith60ListItems.default 262 255 1.03:1
Checkbox.Fluent 770 751 1.03:1
Slider.Fluent 1620 1577 1.03:1
CheckboxMinimalPerf.default 3596 3542 1.02:1
DropdownManyItemsPerf.default 1650 1623 1.02:1
LoaderMinimalPerf.default 1141 1123 1.02:1
MenuMinimalPerf.default 2247 2197 1.02:1
ToolbarMinimalPerf.default 1296 1267 1.02:1
Button.Fluent 569 556 1.02:1
Dialog.Fluent 2143 2106 1.02:1
HeaderMinimalPerf.default 639 631 1.01:1
LayoutMinimalPerf.default 756 750 1.01:1
SegmentMinimalPerf.default 1242 1226 1.01:1
StatusMinimalPerf.default 773 767 1.01:1
TreeMinimalPerf.default 1370 1361 1.01:1
AccordionMinimalPerf.default 274 274 1:1
AnimationMinimalPerf.default 750 752 1:1
DropdownMinimalPerf.default 3999 4009 1:1
EmbedMinimalPerf.default 5762 5784 1:1
FlexMinimalPerf.default 332 333 1:1
ListWith60ListItems.default 1361 1363 1:1
MenuButtonMinimalPerf.default 1753 1755 1:1
PortalMinimalPerf.default 323 323 1:1
ProviderMergeThemesPerf.default 1553 1555 1:1
ProviderMinimalPerf.default 643 645 1:1
TableMinimalPerf.default 767 765 1:1
TooltipMinimalPerf.default 964 963 1:1
Text.Fluent 385 386 1:1
Tooltip.Fluent 644 645 1:1
DividerMinimalPerf.default 1109 1119 0.99:1
HeaderSlotsPerf.default 1893 1910 0.99:1
ItemLayoutMinimalPerf.default 2339 2358 0.99:1
CustomToolbarPrototype.default 3805 3862 0.99:1
VideoMinimalPerf.default 1007 1020 0.99:1
Dropdown.Fluent 3978 4014 0.99:1
AlertMinimalPerf.default 634 644 0.98:1
AttachmentSlotsPerf.default 2691 2744 0.98:1
ButtonSlotsPerf.default 672 685 0.98:1
ChatWithPopoverPerf.default 631 644 0.98:1
TextMinimalPerf.default 386 395 0.98:1
TextAreaMinimalPerf.default 3277 3330 0.98:1
Icon.Fluent 748 760 0.98:1
CarouselMinimalPerf.default 685 709 0.97:1
ListNestedPerf.default 1064 1102 0.97:1
ButtonMinimalPerf.default 164 170 0.96:1
LabelMinimalPerf.default 438 455 0.96:1
ReactionMinimalPerf.default 2569 2674 0.96:1
ChatDuplicateMessagesPerf.default 439 466 0.94:1

@msft-github-bot
Copy link
Contributor

🎉@uifabric/tsx-editor@v0.11.50 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/webpack-utils@v7.0.12 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/theme-samples@v7.0.52 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/utilities@v7.15.7 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/react-hooks@v7.1.3 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/test-utilities@v7.0.17 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react@v7.106.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/monaco-editor@v0.5.7 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/migration@v7.0.16 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/icons@v7.3.26 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/styling@v7.11.3 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/foundation@v7.7.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/example-app-base@v7.12.34 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/examples@v0.1.32 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/mdl2-theme@v0.1.54 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v1.4.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/fluent-theme@v7.1.53 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/fabric-website-resources@v7.6.36 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/azure-themes@v7.0.59 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/fabric-website@v7.10.23 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/api-docs@v7.2.50 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/example-data@v7.0.11 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/experiments@v7.23.2 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/date-time@v7.8.55 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/file-type-icons@v7.2.30 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/react-cards@v0.109.54 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@uifabric/merge-styles@v7.10.0 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉@fluentui/react-compose@v0.2.6 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉office-ui-fabric-react@v7.106.1 has been released which incorporates this pull request.:tada:

Handy links:

DuanShaolong pushed a commit to DuanShaolong/fluentui that referenced this pull request Apr 27, 2020
@ecraig12345 @DuanShaolong
More fabric=>fluent wording updates (microsoft#12508)
9332de2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzearing dzearing dzearing left review comments

@micahgodbolt micahgodbolt micahgodbolt approved these changes

@aneeshack4 aneeshack4 aneeshack4 approved these changes

@khmakoto khmakoto khmakoto approved these changes

@aditima aditima Awaiting requested review from aditima

@bigbadcapers bigbadcapers Awaiting requested review from bigbadcapers

@evlevy evlevy Awaiting requested review from evlevy

@Jahnp Jahnp Awaiting requested review from Jahnp

@JasonGore JasonGore Awaiting requested review from JasonGore

@joschect joschect Awaiting requested review from joschect

@KevinTCoughlin KevinTCoughlin Awaiting requested review from KevinTCoughlin

@natalieethell natalieethell Awaiting requested review from natalieethell

@Raghurk Raghurk Awaiting requested review from Raghurk

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

@layershifter layershifter Awaiting requested review from layershifter

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@mnajdova mnajdova Awaiting requested review from mnajdova

@phkuo phkuo Awaiting requested review from phkuo

@pompomon pompomon Awaiting requested review from pompomon

Assignees

@aneeshack4 aneeshack4

Labels
Area: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ecraig12345 @msft-github-bot @DustyTheBot @dzearing @micahgodbolt @aneeshack4 @khmakoto