chore(Popup): refactor PopupContent to be functional component #12513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
layershifter
commented
Apr 2, 2020
| @@ -2,5 +2,5 @@ import { isConformant } from 'test/specs/commonTests'; | |||
| import PopupContent from 'src/components/Popup/PopupContent'; | |||
|
|
|||
| describe('PopupContent', () => { | |||
| isConformant(PopupContent, { rendersPortal: true }); | |||
There was a problem hiding this comment.
It never rendered Portal 😯
pompomon
reviewed
Apr 2, 2020
…ntent.tsx Co-Authored-By: Roman Sudarikov <pompomon@users.noreply.github.com>
…oft/fluentui into chore/popup-content-to-fc
pompomon
approved these changes
Apr 2, 2020
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ce7ca511daa6798440e675290c69c3ff21830b4f (build) |
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
…soft#12513) * chore(Popup): refactor PopupContent to be functional component * add changelog entry * Update packages/fluentui/react-northstar/src/components/Popup/PopupContent.tsx Co-Authored-By: Roman Sudarikov <pompomon@users.noreply.github.com> * make required to catch missing props * add missing prop Co-authored-by: Roman Sudarikov <pompomon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
As in other components converted to hooks
PopupContentnow passes only these props to styles:placement,pointing.This PR refactors
PopupContentto be functional component, related to #12237.Microsoft Reviewers: Open in CodeFlow