Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(icons): remove icon viewer #12553

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Apr 6, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

This PR removes a set of processed icons and the matching prototype for it. Is not actual anymore.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@DustyTheBot
Copy link

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against d4b9d86

@size-auditor
Copy link

size-auditor bot commented Apr 6, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 19135b8499fb90929bc64cc10be1c2cfaa106bc3 (build)

@mnajdova mnajdova closed this Apr 6, 2020
@mnajdova mnajdova reopened this Apr 6, 2020
@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 796 817 5000
Checkbox 1870 1868 5000
CheckboxBase 1483 1494 5000
ChoiceGroup 5301 5537 5000
CommandBar 11107 11070 1000
DefaultButton 1044 1039 5000
DetailsRow 3365 3301 5000
DetailsRow (fast icons) 3295 3372 5000
DetailsRow without styles 3031 3074 5000
Dialog 7112 7308 5000
DocumentCardTitle with truncation 1500 1513 1000
Dropdown 2957 2868 5000
FocusZone 1582 1501 5000
IconButton 1680 1721 5000
Label 524 500 5000
Link 446 486 5000
MenuButton 1426 1432 5000
Nav 5521 5567 1000
Pivot 1294 1263 1000
PrimaryButton 1173 1230 5000
SearchBox 1478 1491 5000
Slider 1823 1844 5000
Spinner 379 357 5000
SplitButton 3012 2958 5000
Stack 478 459 5000
Stack with Intrinsic children 1070 1067 5000
Stack with Text children 4172 4049 5000
Text 381 373 5000
TextField 1745 1680 5000
Toggle 874 887 5000
button 59 77 5000

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
IconMinimalPerf.default 890 487 1.83:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.61 0.55 1.11:1 2000 1210
🦄 Button.Fluent 0.11 0.2 0.55:1 5000 557
🔧 Checkbox.Fluent 0.78 0.42 1.86:1 1000 782
🔧 Dialog.Fluent 0.43 0.21 2.05:1 5000 2146
🔧 Dropdown.Fluent 3.84 0.51 7.53:1 1000 3839
🔧 Icon.Fluent 0.21 0.05 4.2:1 5000 1025
🎯 Image.Fluent 0.09 0.11 0.82:1 5000 469
🔧 Slider.Fluent 1.68 0.44 3.82:1 1000 1684
🔧 Text.Fluent 0.09 0.02 4.5:1 5000 464
🦄 Tooltip.Fluent 0.14 16.23 0.01:1 5000 709

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 348 310 1.12:1
AlertMinimalPerf.default 673 612 1.1:1
HierarchicalTreeMinimalPerf.default 1248 1149 1.09:1
Image.Fluent 469 435 1.08:1
PortalMinimalPerf.default 349 327 1.07:1
CardMinimalPerf.default 464 436 1.06:1
DividerMinimalPerf.default 1128 1068 1.06:1
ChatDuplicateMessagesPerf.default 499 476 1.05:1
ChatWithPopoverPerf.default 708 675 1.05:1
LabelMinimalPerf.default 473 452 1.05:1
PopupMinimalPerf.default 270 257 1.05:1
RefMinimalPerf.default 219 209 1.05:1
TableMinimalPerf.default 784 747 1.05:1
Text.Fluent 464 444 1.05:1
ListCommonPerf.default 1245 1202 1.04:1
TreeWith60ListItems.default 259 248 1.04:1
Avatar.Fluent 1210 1163 1.04:1
FormMinimalPerf.default 1059 1026 1.03:1
StatusMinimalPerf.default 773 748 1.03:1
ChatMinimalPerf.default 695 679 1.02:1
DropdownMinimalPerf.default 3679 3622 1.02:1
MenuMinimalPerf.default 2196 2158 1.02:1
MenuButtonMinimalPerf.default 1781 1746 1.02:1
Icon.Fluent 1025 1006 1.02:1
AvatarMinimalPerf.default 631 624 1.01:1
BoxMinimalPerf.default 459 453 1.01:1
CarouselMinimalPerf.default 678 672 1.01:1
EmbedMinimalPerf.default 5706 5671 1.01:1
HeaderMinimalPerf.default 641 637 1.01:1
ItemLayoutMinimalPerf.default 2337 2315 1.01:1
LayoutMinimalPerf.default 767 760 1.01:1
ListMinimalPerf.default 552 547 1.01:1
LoaderMinimalPerf.default 1134 1126 1.01:1
TextAreaMinimalPerf.default 3371 3330 1.01:1
Checkbox.Fluent 782 774 1.01:1
Dropdown.Fluent 3839 3798 1.01:1
Slider.Fluent 1684 1666 1.01:1
AccordionMinimalPerf.default 263 263 1:1
AnimationMinimalPerf.default 740 739 1:1
AttachmentSlotsPerf.default 3984 3973 1:1
ButtonSlotsPerf.default 725 723 1:1
HeaderSlotsPerf.default 2010 2003 1:1
ImageMinimalPerf.default 436 436 1:1
InputMinimalPerf.default 1150 1153 1:1
SliderMinimalPerf.default 1639 1637 1:1
TooltipMinimalPerf.default 952 953 1:1
Button.Fluent 557 555 1:1
Dialog.Fluent 2146 2149 1:1
AttachmentMinimalPerf.default 970 979 0.99:1
CheckboxMinimalPerf.default 3419 3469 0.99:1
GridMinimalPerf.default 944 957 0.99:1
ListNestedPerf.default 1060 1069 0.99:1
ProviderMinimalPerf.default 700 705 0.99:1
TextMinimalPerf.default 470 474 0.99:1
CustomToolbarPrototype.default 3932 3973 0.99:1
ToolbarMinimalPerf.default 1268 1276 0.99:1
DialogMinimalPerf.default 2079 2118 0.98:1
SplitButtonMinimalPerf.default 3868 3942 0.98:1
TreeMinimalPerf.default 1316 1341 0.98:1
VideoMinimalPerf.default 1023 1046 0.98:1
Tooltip.Fluent 709 721 0.98:1
ListWith60ListItems.default 1376 1416 0.97:1
ProviderMergeThemesPerf.default 1529 1580 0.97:1
RadioGroupMinimalPerf.default 636 653 0.97:1
ReactionMinimalPerf.default 2616 2719 0.96:1
ButtonMinimalPerf.default 166 174 0.95:1
SegmentMinimalPerf.default 1196 1275 0.94:1
DropdownManyItemsPerf.default 1578 1785 0.88:1

@mnajdova mnajdova merged commit b0fd561 into microsoft:master Apr 6, 2020
DuanShaolong pushed a commit to DuanShaolong/fluentui that referenced this pull request Apr 27, 2020
* -removed processed icons

* -removed test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants