fix(Tooltip): don't add aria-labelled by if aria-label is passed to Tooltip or trigger #12555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 2c98aa23ebc33ac6005ce2eaff949f8eb27b16a0 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
kolaps33
reviewed
Apr 7, 2020
| @@ -10,30 +14,21 @@ import tooltipAsDescriptionBehavior, { TooltipBehaviorProps } from './tooltipAsD | |||
| */ | |||
| const tooltipAsLabelBehavior: Accessibility<TooltipBehaviorProps> = props => { | |||
| const behaviorData = tooltipAsDescriptionBehavior(props); | |||
| const defaultAriaLabeledBy = getDefaultAriaLabelledBy(props); | |||
| const triggerAriaLabel = props.triggerAriaLabel || props['aria-label']; | |||
There was a problem hiding this comment.
I am not sure here if should we take into the "triggerAriaLabel" the "aria-label" prop which comes from Tooltip ?
When I tried to simulate, then "aria-label" which was set on the Tooltip is set on the trigger button. (of course different question is why would someone set aria-label on the Tooltip)
There was a problem hiding this comment.
if there is a aria-label on the tooltip, it should just stay on the tooltip and should not be applied on the trigger I think
There was a problem hiding this comment.
I am now considering aria-label from trigger when I am conditionally applying aria-labelledby.
As for that classname, I fixed it by removing the classname and using another selector in the test. should be fine now
kolaps33
approved these changes
Apr 7, 2020
layershifter
reviewed
Apr 7, 2020
| <Ref innerRef={triggerRef}>{React.cloneElement(triggerElement, getA11Props('trigger', triggerProps))}</Ref> | ||
| <Ref innerRef={triggerRef}> | ||
| {React.cloneElement(triggerElement, { | ||
| className: Tooltip.slotClassNames.trigger, |
There was a problem hiding this comment.
Let's avoid doing this as it will silently override existing className on a trigger
There was a problem hiding this comment.
So what do you suggest? Doing a cx composition of classes for that? I need to get that triggerElement in tests so I need the slot class.
There was a problem hiding this comment.
cx can work, but in this case it should be done also in Popup. However, I don't like this option as trigger is not a real slot.
If it's only for tests I don't see any blocker to use Button.className or use a specific classname on it.
There was a problem hiding this comment.
removed, using button class now.
jurokapsiar
approved these changes
Apr 7, 2020
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
…rigger (microsoft#12555) * include trigger aria-label to behavior props * send trigger aria-label to behavior * fix behavior to not add aria-labelledby * add unit tests * changelog * do not consider Tooltip aria-label for this fix * remove trigger slot classname * change changelog message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Checks for
aria-labelledin either therootprops ortriggerprops. If found in any, will not addaria-labelledbyontrigger.Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow