Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An update for RaiseHandColoredIcon #12618

Merged
merged 2 commits into from
Apr 9, 2020
Merged

An update for RaiseHandColoredIcon #12618

merged 2 commits into from
Apr 9, 2020

Conversation

TanelVari
Copy link
Contributor

@TanelVari TanelVari commented Apr 9, 2020 •
edited by msft-github-bot

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Apr 9, 2020
@size-auditor
Copy link

size-auditor bot commented Apr 9, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 41dcfb48c91fdbb12d68d503bea0441bc6f85449 (build)

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Apr 9, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 758 756 5000
Checkbox 1705 1682 5000
CheckboxBase 1357 1345 5000
ChoiceGroup 4834 4981 5000
CommandBar 7128 6991 1000
DefaultButton 963 961 5000
DetailsRow 3128 3086 5000
DetailsRow (fast icons) 3069 3046 5000
DetailsRow without styles 2941 2910 5000
Dialog 6711 6749 5000
DocumentCardTitle with truncation 1521 1563 1000
Dropdown 2606 2694 5000
FocusZone 1491 1531 5000
IconButton 1563 1598 5000
Label 437 443 5000
Link 421 406 5000
MenuButton 1273 1289 5000
Nav 2918 2913 1000
Pivot 1193 1200 1000
PrimaryButton 1104 1113 5000
SearchBox 1326 1331 5000
Slider 1643 1637 5000
Spinner 349 350 5000
SplitButton 2763 2691 5000
Stack 413 423 5000
Stack with Intrinsic children 1019 986 5000
Stack with Text children 3567 3677 5000
Text 315 321 5000
TextField 1561 1586 5000
Toggle 778 782 5000
button 53 71 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.56 0.47 1.19:1 2000 1118
🦄 Button.Fluent 0.1 0.18 0.56:1 5000 481
🔧 Checkbox.Fluent 0.72 0.38 1.89:1 1000 718
🔧 Dialog.Fluent 0.38 0.19 2:1 5000 1919
🔧 Dropdown.Fluent 3.89 0.45 8.64:1 1000 3889
🔧 Icon.Fluent 0.13 0.05 2.6:1 5000 661
🎯 Image.Fluent 0.07 0.09 0.78:1 5000 338
🔧 Slider.Fluent 1.64 0.37 4.43:1 1000 1639
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 351
🦄 Tooltip.Fluent 0.12 17.81 0.01:1 5000 598

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ImageMinimalPerf.default 354 322 1.1:1
DividerMinimalPerf.default 1041 951 1.09:1
HeaderMinimalPerf.default 523 480 1.09:1
BoxMinimalPerf.default 311 289 1.08:1
TableMinimalPerf.default 672 636 1.06:1
AttachmentMinimalPerf.default 148 141 1.05:1
ButtonMinimalPerf.default 143 136 1.05:1
ChatMinimalPerf.default 603 574 1.05:1
LoaderMinimalPerf.default 1086 1036 1.05:1
HierarchicalTreeMinimalPerf.default 995 958 1.04:1
ListMinimalPerf.default 454 436 1.04:1
ToolbarMinimalPerf.default 1089 1052 1.04:1
Avatar.Fluent 1118 1074 1.04:1
Slider.Fluent 1639 1570 1.04:1
ListNestedPerf.default 962 930 1.03:1
PortalMinimalPerf.default 291 282 1.03:1
ProviderMinimalPerf.default 640 624 1.03:1
RadioGroupMinimalPerf.default 532 516 1.03:1
ReactionMinimalPerf.default 2508 2434 1.03:1
Tooltip.Fluent 598 582 1.03:1
CardMinimalPerf.default 379 373 1.02:1
DropdownManyItemsPerf.default 1517 1486 1.02:1
InputMinimalPerf.default 1085 1066 1.02:1
ItemLayoutMinimalPerf.default 2087 2052 1.02:1
MenuButtonMinimalPerf.default 1540 1506 1.02:1
SegmentMinimalPerf.default 1091 1072 1.02:1
CustomToolbarPrototype.default 3807 3723 1.02:1
Button.Fluent 481 473 1.02:1
AttachmentSlotsPerf.default 2606 2572 1.01:1
ButtonSlotsPerf.default 620 612 1.01:1
EmbedMinimalPerf.default 5600 5571 1.01:1
LabelMinimalPerf.default 380 377 1.01:1
TooltipMinimalPerf.default 857 845 1.01:1
TreeMinimalPerf.default 1171 1159 1.01:1
VideoMinimalPerf.default 862 850 1.01:1
Dropdown.Fluent 3889 3864 1.01:1
Text.Fluent 351 346 1.01:1
CheckboxMinimalPerf.default 3327 3323 1:1
HeaderSlotsPerf.default 1652 1644 1:1
PopupMinimalPerf.default 236 236 1:1
ProviderMergeThemesPerf.default 1499 1502 1:1
SliderMinimalPerf.default 1595 1601 1:1
TextMinimalPerf.default 315 315 1:1
TextAreaMinimalPerf.default 3180 3193 1:1
Checkbox.Fluent 718 719 1:1
Icon.Fluent 661 663 1:1
DropdownMinimalPerf.default 3881 3938 0.99:1
FormMinimalPerf.default 909 920 0.99:1
ListWith60ListItems.default 1215 1232 0.99:1
MenuMinimalPerf.default 2004 2021 0.99:1
RefMinimalPerf.default 185 186 0.99:1
SplitButtonMinimalPerf.default 3599 3639 0.99:1
StatusMinimalPerf.default 637 642 0.99:1
Dialog.Fluent 1919 1947 0.99:1
AlertMinimalPerf.default 594 606 0.98:1
CarouselMinimalPerf.default 613 627 0.98:1
FlexMinimalPerf.default 260 266 0.98:1
ListCommonPerf.default 1006 1026 0.98:1
AnimationMinimalPerf.default 606 627 0.97:1
ChatWithPopoverPerf.default 617 634 0.97:1
LayoutMinimalPerf.default 626 644 0.97:1
Image.Fluent 338 347 0.97:1
DialogMinimalPerf.default 1919 1993 0.96:1
IconMinimalPerf.default 608 631 0.96:1
ChatDuplicateMessagesPerf.default 416 439 0.95:1
TreeWith60ListItems.default 230 242 0.95:1
AccordionMinimalPerf.default 220 235 0.94:1
GridMinimalPerf.default 774 826 0.94:1
AvatarMinimalPerf.default 555 596 0.93:1

@mnajdova
Copy link
Contributor

mnajdova commented Apr 9, 2020

Please provide changelog entry and accepts screener diffs before merging

@TanelVari TanelVari closed this Apr 9, 2020
@TanelVari TanelVari reopened this Apr 9, 2020
@TanelVari TanelVari merged commit 9c0cebc into microsoft:master Apr 9, 2020
DuanShaolong pushed a commit to DuanShaolong/fluentui that referenced this pull request Apr 27, 2020
@TanelVari @DuanShaolong
An update for RaiseHandColoredIcon (microsoft#12618)
b2450d3 
* An update for RaiseHandColoredIcon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@layershifter layershifter Awaiting requested review from layershifter

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@pompomon pompomon Awaiting requested review from pompomon

Assignees

@joschect joschect

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TanelVari @msft-github-bot @mnajdova @joschect