feat(docs): Add Icon viewer page #12645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1ed7214e0bc984ccee034e3e30a0975ed0371ebc (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
mnajdova
commented
Apr 14, 2020
| @@ -165,6 +165,15 @@ class Sidebar extends React.Component<any, any> { | |||
| to: '/shorthand-props', | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Now that we have the viewer we may even hide from public the example with all icons, and add link on the SvgIcon's docs page for the icons viewer... I am open for other ideas/suggestions here
| /> | ||
| <Flex wrap gap="gap.medium" styles={iconFlexStyles}> | ||
| {filteredIcons.map(Icon => ( | ||
| <Flex.Item align="center" key={Icon.displayName}> |
There was a problem hiding this comment.
Should we extract this to a component?
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
layershifter
approved these changes
Apr 14, 2020
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
* wip * -fixed on the navigation buttons * -added more info * -fixed ts issue * Update packages/fluentui/docs/src/views/IconViewer.tsx Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/fluentui/docs/src/views/IconViewer.tsx Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * -changed state to reducer * -added ComponentPlaygroundSnippet & fixed styles * -updated changelog Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
(give an overview)
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow