feat(Avatar): add icon prop #12660
Merged
feat(Avatar): add icon prop #12660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 7927551e96fa5b7572425d947b58ba07c826f401 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
| @@ -0,0 +1,13 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
Should be this example in Slots section?
There was a problem hiding this comment.
Probably, but then we should restructure all examples, as we don't even have slots examples here. I will just leave it now after the image example, and we can restructure the examples in a separate PR.
packages/fluentui/react-northstar/src/components/Avatar/Avatar.tsx
Outdated
Show resolved
Hide resolved
| }), | ||
| })} | ||
| {!image && | ||
| !icon && | ||
| Label.create(label || {}, { |
There was a problem hiding this comment.
Not related to your changes, but this is not cool as if I will pass there null the slot will be still rendered
packages/fluentui/react-northstar/src/themes/teams/components/Avatar/avatarStyles.ts
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Apr 14, 2020
pompomon
reviewed
Apr 14, 2020
packages/fluentui/react-northstar/src/components/Avatar/Avatar.tsx
Outdated
Show resolved
Hide resolved
…Avatar/avatarStyles.ts Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
* -added icon prop inside Avatar * -updated changelog * Update packages/fluentui/react-northstar/src/themes/teams/components/Avatar/avatarStyles.ts Co-Authored-By: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * -addressed comments Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
(give an overview)
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow