chore: Attachment use compose() #12674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0b9847bc9bfdc1c4a0cb35ce0cfcfdc32880500b (build) |
layershifter
force-pushed
the
chore/attachment-use-compose
branch
from
860840a
to
a01ad8c
Compare
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
layershifter
commented
Apr 14, 2020
| @@ -34,8 +34,9 @@ export const getTelemetry = (displayName: string, telemetry: Telemetry | undefin | |||
|
|
|||
| const useTelemetry = (displayName: string, telemetry: Telemetry | undefined): UseTelemetryResult => { | |||
| const composeOptions = useComposeOptions(); | |||
| const telemetryName = composeOptions?.displayNames[composeOptions?.displayNames.length - 1] || displayName; | |||
There was a problem hiding this comment.
Oops, the actual name is the last one
layershifter
changed the title
mnajdova
reviewed
Apr 14, 2020
| {Text.create(description, { | ||
| defaultProps: () => ({ styles: resolvedStyles.description }), | ||
| })} | ||
| <div className="ui-attachment__content"> |
There was a problem hiding this comment.
Just curious, why we don't have AttachmentBody component that will have the header and description props and we would create those inside that component?
mnajdova
reviewed
Apr 14, 2020
packages/fluentui/react-northstar/src/components/Attachment/Attachment.tsx
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Apr 14, 2020
| {!_.isNil(progress) && <div className={classes.progress} style={{ width: `${progress}%` }} />} | ||
|
|
||
| {AttachmentAction.create(action)} | ||
| {!_.isNil(progress) && <div className="ui-attachment__progress" style={{ width: `${progress}%` }} />} |
There was a problem hiding this comment.
Why we don't have AttachmentProgress component? I understand that you are just mapping shorthands to components, so I'm just interested whether there is a solid reason for it not being one
mnajdova
reviewed
Apr 14, 2020
| })} | ||
| {!_.isNil(progress) && <div className={classes.progress} style={{ width: `${progress}%` }} />} | ||
|
|
||
| {AttachmentAction.create(action)} |
There was a problem hiding this comment.
It's interesting that none of the sub-components need any of the parent's props :)
mnajdova
reviewed
Apr 14, 2020
packages/fluentui/react-northstar/test/specs/commonTests/isConformant.tsx
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Apr 14, 2020
| flex: 1, | ||
| }, | ||
|
|
||
| '& .ui-attachment__progress': { |
There was a problem hiding this comment.
It's not obvious why this is implemented with selector. I would vote for a separate component, to keep it consistent with other slots..
…/github.com/microsoft/fluentui into chore/attachment-use-compose � Conflicts: � packages/fluentui/react-northstar/src/themes/teams-dark/componentVariables.ts
…/github.com/microsoft/fluentui into chore/attachment-use-compose � Conflicts: � packages/fluentui/CHANGELOG.md
mnajdova
approved these changes
Apr 15, 2020
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
* chore: Attachment use compose() * fix duplicate import * fix more regressions * fix UT * fix import paths * fix UTs * fix styles * fix regressions * fix acc * fix more issues * uses button variables instead * revert a change * address review comments * fix UTs * introduce body slot * update changelog * fix keys * add UT for body, add export and static field * add missing proptype * fix changelog
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeBREAKING CHANGES
slotClassNamesremovalslotClassNameswere removed fromAttachment, please use classnames on matching components instead.styleswere moved to components from slotsaction,description,icon&headerslots were moved to separate componentscontentslots were moved to separateAttachmentBodyprogressslot are not separated anymore and should be used onrootinattachmentStylesBefore
After
Description of changes
This PR updates
Attachmentto use insteadBoxes composed components.Adds
bodyslot toAttachment.Performance
Due enabled caching performance for rerenders was improved improved almost twice 🚀
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow