Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: export className and slotClassName consts and replace statics usages part 1 #12706

Merged
merged 4 commits into from
Apr 16, 2020
Merged

chore: export className and slotClassName consts and replace statics usages part 1 #12706

merged 4 commits into from
Apr 16, 2020

Conversation

mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Apr 15, 2020 •
edited by msft-github-bot

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Apr 15, 2020
@mnajdova mnajdova changed the title chore(Accordion | Alert | Animation | Attachment | Avatar): export classNames and slotClassName consts and replace statics usages chore(Accordion|Alert|Animation|Attachment|Avatar): export className and slotClassName consts and replace statics usages Apr 15, 2020
@mnajdova mnajdova changed the title chore(Accordion|Alert|Animation|Attachment|Avatar): export className and slotClassName consts and replace statics usages chore: export className and slotClassName consts and replace statics usages part 1 Apr 15, 2020
@size-auditor
Copy link

size-auditor bot commented Apr 15, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0eb5b3bcb86468253ae8492ffb0dadcdbf016b67 (build)

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 752 745 5000
Checkbox 1675 1702 5000
CheckboxBase 1343 1263 5000
ChoiceGroup 4762 4906 5000
ComboBox 891 877 1000
CommandBar 6781 6865 1000
DefaultButton 976 971 5000
DetailsRow 3116 3133 5000
DetailsRow (fast icons) 3146 3096 5000
DetailsRow without styles 2911 2897 5000
Dialog 1342 1357 1000
DocumentCardTitle with truncation 1570 1540 1000
Dropdown 2676 2711 5000
FocusZone 1454 1543 5000
IconButton 1521 1514 5000
Label 442 442 5000
Link 411 426 5000
MenuButton 1282 1305 5000
Nav 2943 2878 1000
Panel 1319 1305 1000
Persona 738 743 1000
Pivot 1230 1190 1000
PrimaryButton 1107 1130 5000
SearchBox 1393 1402 5000
Slider 1663 1674 5000
Spinner 359 352 5000
SplitButton 2784 2796 5000
Stack 413 437 5000
Stack with Intrinsic children 1016 1031 5000
Stack with Text children 3726 3781 5000
TagPicker 2383 2401 5000
Text 324 348 5000
TextField 1608 1610 5000
Toggle 808 802 5000
button 67 55 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.47 0.94:1 2000 878
🦄 Button.Fluent 0.09 0.17 0.53:1 5000 448
🔧 Checkbox.Fluent 0.6 0.35 1.71:1 1000 598
🔧 Dialog.Fluent 0.31 0.17 1.82:1 5000 1543
🔧 Dropdown.Fluent 2.93 0.44 6.66:1 1000 2934
🔧 Icon.Fluent 0.13 0.04 3.25:1 5000 642
🎯 Image.Fluent 0.07 0.09 0.78:1 5000 347
🔧 Slider.Fluent 1.27 0.39 3.26:1 1000 1271
🔧 Text.Fluent 0.06 0.02 3:1 5000 323
🦄 Tooltip.Fluent 0.08 16.29 0:1 5000 420

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
VideoMinimalPerf.default 765 712 1.07:1
ListNestedPerf.default 874 835 1.05:1
SliderMinimalPerf.default 1374 1303 1.05:1
IconMinimalPerf.default 624 593 1.05:1
ToolbarMinimalPerf.default 978 935 1.05:1
Dialog.Fluent 1543 1467 1.05:1
AccordionMinimalPerf.default 198 190 1.04:1
ButtonSlotsPerf.default 571 548 1.04:1
CardMinimalPerf.default 374 358 1.04:1
GridMinimalPerf.default 624 598 1.04:1
HierarchicalTreeMinimalPerf.default 911 879 1.04:1
ListMinimalPerf.default 456 438 1.04:1
PopupMinimalPerf.default 250 241 1.04:1
RefMinimalPerf.default 195 187 1.04:1
TextMinimalPerf.default 335 322 1.04:1
Icon.Fluent 642 620 1.04:1
HeaderSlotsPerf.default 1371 1331 1.03:1
LayoutMinimalPerf.default 511 497 1.03:1
PortalMinimalPerf.default 279 272 1.03:1
Tooltip.Fluent 420 408 1.03:1
AvatarMinimalPerf.default 489 479 1.02:1
DropdownManyItemsPerf.default 1292 1265 1.02:1
HeaderMinimalPerf.default 436 427 1.02:1
ListCommonPerf.default 936 917 1.02:1
StatusMinimalPerf.default 662 651 1.02:1
Slider.Fluent 1271 1245 1.02:1
AnimationMinimalPerf.default 599 593 1.01:1
AttachmentMinimalPerf.default 136 135 1.01:1
ChatDuplicateMessagesPerf.default 387 384 1.01:1
ChatMinimalPerf.default 577 569 1.01:1
LabelMinimalPerf.default 373 368 1.01:1
MenuButtonMinimalPerf.default 1451 1438 1.01:1
ProviderMinimalPerf.default 656 647 1.01:1
CustomToolbarPrototype.default 3467 3421 1.01:1
TooltipMinimalPerf.default 666 662 1.01:1
Avatar.Fluent 878 871 1.01:1
Image.Fluent 347 344 1.01:1
AlertMinimalPerf.default 500 501 1:1
CarouselMinimalPerf.default 576 578 1:1
ChatWithPopoverPerf.default 566 564 1:1
CheckboxMinimalPerf.default 2790 2788 1:1
EmbedMinimalPerf.default 4052 4037 1:1
InputMinimalPerf.default 930 926 1:1
ProviderMergeThemesPerf.default 1576 1571 1:1
RadioGroupMinimalPerf.default 518 517 1:1
SplitButtonMinimalPerf.default 3458 3447 1:1
TreeMinimalPerf.default 1087 1089 1:1
Button.Fluent 448 448 1:1
DividerMinimalPerf.default 655 661 0.99:1
FlexMinimalPerf.default 274 276 0.99:1
ImageMinimalPerf.default 343 347 0.99:1
ItemLayoutMinimalPerf.default 1535 1552 0.99:1
LoaderMinimalPerf.default 731 742 0.99:1
MenuMinimalPerf.default 1677 1701 0.99:1
Dropdown.Fluent 2934 2962 0.99:1
BoxMinimalPerf.default 307 312 0.98:1
ListWith60ListItems.default 1075 1098 0.98:1
ReactionMinimalPerf.default 1730 1760 0.98:1
TableMinimalPerf.default 488 496 0.98:1
TextAreaMinimalPerf.default 2515 2571 0.98:1
Checkbox.Fluent 598 613 0.98:1
AttachmentSlotsPerf.default 1029 1062 0.97:1
ButtonMinimalPerf.default 146 151 0.97:1
FormMinimalPerf.default 677 696 0.97:1
SegmentMinimalPerf.default 875 903 0.97:1
Text.Fluent 323 334 0.97:1
DialogMinimalPerf.default 1558 1616 0.96:1
TreeWith60ListItems.default 203 211 0.96:1
DropdownMinimalPerf.default 3014 3357 0.9:1

@mnajdova mnajdova merged commit ac4cfe8 into microsoft:master Apr 16, 2020
DuanShaolong pushed a commit to DuanShaolong/fluentui that referenced this pull request Apr 27, 2020
@mnajdova @DuanShaolong
chore: export className and slotClassName consts and replace statics …
5d88e2d 
…usages part 1 (microsoft#12706)

* -added classNames and slotClassNames consts

* -changed Accordion* and Attachment* static usages

* -replaced Animation, Attachment* and Avatar statics usages

* -added changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@pompomon pompomon Awaiting requested review from pompomon

Assignees

@joschect joschect

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnajdova @msft-github-bot @layershifter @joschect