Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: export consts for className and slotClassNames and remove internal static usages part 4 #12734

Merged
merged 5 commits into from
Apr 16, 2020
Merged

chore: export consts for className and slotClassNames and remove internal static usages part 4 #12734

merged 5 commits into from
Apr 16, 2020

Conversation

mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Apr 16, 2020 •
edited by msft-github-bot

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Apr 16, 2020
@size-auditor
Copy link

size-auditor bot commented Apr 16, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b80a2a26322e073cf565fef97f55041c80a42620 (build)

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 780 744 5000
Checkbox 1722 1736 5000
CheckboxBase 1358 1354 5000
ChoiceGroup 4727 4972 5000
ComboBox 927 922 1000
CommandBar 6461 6739 1000
DefaultButton 967 981 5000
DetailsRow 3002 3002 5000
DetailsRow (fast icons) 3009 2967 5000
DetailsRow without styles 2797 2879 5000
Dialog 1296 1289 1000
DocumentCardTitle with truncation 1483 1478 1000
Dropdown 2801 3057 5000
FocusZone 1385 1387 5000
IconButton 1506 1525 5000
Label 450 451 5000
Link 404 399 5000
MenuButton 1365 1346 5000
Nav 2819 2834 1000
Panel 1291 1321 1000
Persona 721 738 1000
Pivot 1166 1117 1000
PrimaryButton 1074 1081 5000
SearchBox 1410 1283 5000
Slider 1668 1699 5000
Spinner 362 338 5000
SplitButton 2765 2825 5000
Stack 395 438 5000
Stack with Intrinsic children 964 1001 5000
Stack with Text children 3958 3961 5000
TagPicker 2505 2464 5000
Text 340 338 5000
TextField 1607 1660 5000
Toggle 798 797 5000
button 52 49 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.45 0.43 1.05:1 2000 894
🦄 Button.Fluent 0.1 0.18 0.56:1 5000 499
🔧 Checkbox.Fluent 0.57 0.34 1.68:1 1000 573
🔧 Dialog.Fluent 0.32 0.18 1.78:1 5000 1604
🔧 Dropdown.Fluent 2.91 0.44 6.61:1 1000 2906
🔧 Icon.Fluent 0.13 0.05 2.6:1 5000 658
🎯 Image.Fluent 0.07 0.09 0.78:1 5000 352
🔧 Slider.Fluent 1.18 0.39 3.03:1 1000 1180
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 354
🦄 Tooltip.Fluent 0.09 12.22 0.01:1 5000 434

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TextAreaMinimalPerf.default 2784 2406 1.16:1
AnimationMinimalPerf.default 695 618 1.12:1
PopupMinimalPerf.default 224 204 1.1:1
ListMinimalPerf.default 463 424 1.09:1
TextMinimalPerf.default 402 372 1.08:1
Text.Fluent 354 328 1.08:1
FlexMinimalPerf.default 299 282 1.06:1
ImageMinimalPerf.default 377 355 1.06:1
RefMinimalPerf.default 169 160 1.06:1
AttachmentMinimalPerf.default 140 133 1.05:1
TableMinimalPerf.default 619 592 1.05:1
Tooltip.Fluent 434 415 1.05:1
BoxMinimalPerf.default 314 303 1.04:1
LabelMinimalPerf.default 404 390 1.04:1
ListCommonPerf.default 961 922 1.04:1
SplitButtonMinimalPerf.default 3498 3367 1.04:1
Button.Fluent 499 479 1.04:1
Dropdown.Fluent 2906 2791 1.04:1
CardMinimalPerf.default 413 402 1.03:1
ChatMinimalPerf.default 598 581 1.03:1
DividerMinimalPerf.default 711 692 1.03:1
HierarchicalTreeMinimalPerf.default 934 908 1.03:1
ListNestedPerf.default 844 823 1.03:1
MenuButtonMinimalPerf.default 1457 1410 1.03:1
RadioGroupMinimalPerf.default 541 527 1.03:1
TooltipMinimalPerf.default 685 663 1.03:1
AttachmentSlotsPerf.default 1063 1045 1.02:1
ChatDuplicateMessagesPerf.default 379 372 1.02:1
EmbedMinimalPerf.default 3951 3877 1.02:1
LoaderMinimalPerf.default 715 698 1.02:1
MenuMinimalPerf.default 1666 1641 1.02:1
PortalMinimalPerf.default 269 263 1.02:1
ProviderMinimalPerf.default 513 505 1.02:1
AlertMinimalPerf.default 483 477 1.01:1
CarouselMinimalPerf.default 514 508 1.01:1
FormMinimalPerf.default 685 678 1.01:1
HeaderSlotsPerf.default 1420 1409 1.01:1
InputMinimalPerf.default 853 842 1.01:1
IconMinimalPerf.default 692 684 1.01:1
ButtonSlotsPerf.default 541 541 1:1
ChatWithPopoverPerf.default 536 538 1:1
DialogMinimalPerf.default 1576 1573 1:1
GridMinimalPerf.default 636 638 1:1
LayoutMinimalPerf.default 537 536 1:1
SegmentMinimalPerf.default 873 877 1:1
TreeMinimalPerf.default 1125 1130 1:1
Icon.Fluent 658 656 1:1
AccordionMinimalPerf.default 187 189 0.99:1
AvatarMinimalPerf.default 480 483 0.99:1
DropdownMinimalPerf.default 2844 2861 0.99:1
ProviderMergeThemesPerf.default 1273 1283 0.99:1
SliderMinimalPerf.default 1201 1212 0.99:1
Dialog.Fluent 1604 1619 0.99:1
Slider.Fluent 1180 1193 0.99:1
ButtonMinimalPerf.default 143 146 0.98:1
CheckboxMinimalPerf.default 2587 2647 0.98:1
Avatar.Fluent 894 910 0.98:1
Checkbox.Fluent 573 583 0.98:1
ItemLayoutMinimalPerf.default 1523 1567 0.97:1
ListWith60ListItems.default 1033 1068 0.97:1
StatusMinimalPerf.default 713 735 0.97:1
CustomToolbarPrototype.default 3078 3157 0.97:1
ToolbarMinimalPerf.default 952 986 0.97:1
HeaderMinimalPerf.default 461 479 0.96:1
ReactionMinimalPerf.default 1619 1681 0.96:1
TreeWith60ListItems.default 205 214 0.96:1
Image.Fluent 352 366 0.96:1
DropdownManyItemsPerf.default 1174 1234 0.95:1
VideoMinimalPerf.default 745 813 0.92:1

@mnajdova mnajdova merged commit 9729eb7 into microsoft:master Apr 16, 2020
DuanShaolong pushed a commit to DuanShaolong/fluentui that referenced this pull request Apr 27, 2020
@mnajdova @DuanShaolong
chore: export consts for className and slotClassNames and remove inte…
b97c8cc 
…rnal static usages part 4 (microsoft#12734)

* -converted Dialog* components

* -converted Divider and Dropdown* components

* -converted Embed component

* -updated changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@pompomon pompomon Awaiting requested review from pompomon

Assignees

@joschect joschect

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mnajdova @msft-github-bot @layershifter @joschect