Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Card): Add disabled prop #12743

Merged
merged 3 commits into from
Apr 17, 2020
Merged

feat(Card): Add disabled prop #12743

merged 3 commits into from
Apr 17, 2020

Conversation

pompomon
Copy link
Contributor

@pompomon pompomon commented Apr 16, 2020 •
edited by msft-github-bot

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Add disabled prop and styles to Card

image

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Apr 16, 2020
@size-auditor
Copy link

size-auditor bot commented Apr 16, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d8a2780c9e811136241a0b21985e379f0a29e23e (build)

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Apr 16, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 789 752 5000
Checkbox 1777 1754 5000
CheckboxBase 1394 1420 5000
ChoiceGroup 5170 5272 5000
ComboBox 917 932 1000
CommandBar 7607 7308 1000
ContextualMenu 21538 21973 1000
DefaultButton 1039 1021 5000
DetailsRow 3214 3260 5000
DetailsRow (fast icons) 3242 3253 5000
DetailsRow without styles 3079 3025 5000
Dialog 1427 1368 1000
DocumentCardTitle with truncation 1620 1618 1000
Dropdown 2799 2794 5000
FocusZone 1572 1545 5000
IconButton 1575 1640 5000
Label 452 467 5000
Link 423 435 5000
MenuButton 1341 1349 5000
Nav 3013 3061 1000
Panel 1410 1381 1000
Persona 797 808 1000
Pivot 1247 1280 1000
PrimaryButton 1134 1159 5000
SearchBox 1458 1406 5000
Slider 1795 1792 5000
Spinner 380 376 5000
SplitButton 2933 2883 5000
Stack 420 452 5000
Stack with Intrinsic children 1097 1094 5000
Stack with Text children 3912 3891 5000
TagPicker 2595 2599 5000
Text 362 347 5000
TextField 1625 1679 5000
Toggle 849 827 5000
button 58 61 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.46 0.48 0.96:1 2000 925
🦄 Button.Fluent 0.1 0.18 0.56:1 5000 481
🔧 Checkbox.Fluent 0.62 0.38 1.63:1 1000 624
🔧 Dialog.Fluent 0.34 0.19 1.79:1 5000 1714
🔧 Dropdown.Fluent 3.26 0.46 7.09:1 1000 3264
🔧 Icon.Fluent 0.14 0.04 3.5:1 5000 691
🎯 Image.Fluent 0.08 0.1 0.8:1 5000 376
🔧 Slider.Fluent 1.4 0.41 3.41:1 1000 1402
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 369
🦄 Tooltip.Fluent 0.09 17.25 0.01:1 5000 453

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
CarouselMinimalPerf.default 605 571 1.06:1
TableMinimalPerf.default 542 513 1.06:1
Text.Fluent 369 350 1.05:1
HeaderSlotsPerf.default 1445 1383 1.04:1
LabelMinimalPerf.default 402 385 1.04:1
ListNestedPerf.default 890 859 1.04:1
PortalMinimalPerf.default 299 288 1.04:1
TreeWith60ListItems.default 223 215 1.04:1
Dialog.Fluent 1714 1643 1.04:1
Icon.Fluent 691 667 1.04:1
Image.Fluent 376 360 1.04:1
AlertMinimalPerf.default 536 520 1.03:1
PopupMinimalPerf.default 267 258 1.03:1
CustomToolbarPrototype.default 3701 3607 1.03:1
TooltipMinimalPerf.default 719 698 1.03:1
Dropdown.Fluent 3264 3179 1.03:1
CardMinimalPerf.default 553 542 1.02:1
ChatDuplicateMessagesPerf.default 415 405 1.02:1
GridMinimalPerf.default 640 625 1.02:1
HeaderMinimalPerf.default 475 465 1.02:1
InputMinimalPerf.default 982 967 1.02:1
ListWith60ListItems.default 1170 1147 1.02:1
SegmentMinimalPerf.default 926 904 1.02:1
TreeMinimalPerf.default 1131 1105 1.02:1
VideoMinimalPerf.default 772 758 1.02:1
Slider.Fluent 1402 1379 1.02:1
ChatMinimalPerf.default 607 601 1.01:1
DropdownMinimalPerf.default 3244 3217 1.01:1
FlexMinimalPerf.default 294 291 1.01:1
FormMinimalPerf.default 709 705 1.01:1
HierarchicalTreeMinimalPerf.default 961 954 1.01:1
ImageMinimalPerf.default 375 373 1.01:1
ItemLayoutMinimalPerf.default 1600 1581 1.01:1
ListMinimalPerf.default 462 458 1.01:1
ReactionMinimalPerf.default 1897 1875 1.01:1
SplitButtonMinimalPerf.default 3710 3673 1.01:1
StatusMinimalPerf.default 664 655 1.01:1
TextMinimalPerf.default 351 346 1.01:1
AttachmentSlotsPerf.default 1101 1106 1:1
BoxMinimalPerf.default 330 329 1:1
CheckboxMinimalPerf.default 2921 2911 1:1
DialogMinimalPerf.default 1651 1654 1:1
ListCommonPerf.default 963 961 1:1
LoaderMinimalPerf.default 769 767 1:1
MenuMinimalPerf.default 1770 1762 1:1
ProviderMinimalPerf.default 653 656 1:1
IconMinimalPerf.default 642 641 1:1
TextAreaMinimalPerf.default 2731 2725 1:1
ToolbarMinimalPerf.default 968 965 1:1
Button.Fluent 481 481 1:1
DividerMinimalPerf.default 688 695 0.99:1
MenuButtonMinimalPerf.default 1547 1569 0.99:1
ButtonMinimalPerf.default 158 161 0.98:1
DropdownManyItemsPerf.default 1371 1396 0.98:1
LayoutMinimalPerf.default 529 539 0.98:1
RadioGroupMinimalPerf.default 546 557 0.98:1
SliderMinimalPerf.default 1345 1378 0.98:1
Avatar.Fluent 925 944 0.98:1
Tooltip.Fluent 453 464 0.98:1
AnimationMinimalPerf.default 625 642 0.97:1
AvatarMinimalPerf.default 484 497 0.97:1
EmbedMinimalPerf.default 4216 4328 0.97:1
ProviderMergeThemesPerf.default 1599 1642 0.97:1
RefMinimalPerf.default 186 192 0.97:1
Checkbox.Fluent 624 641 0.97:1
AttachmentMinimalPerf.default 134 139 0.96:1
ButtonSlotsPerf.default 567 593 0.96:1
ChatWithPopoverPerf.default 585 607 0.96:1
AccordionMinimalPerf.default 187 200 0.94:1

@pompomon pompomon changed the title Add disabled prop to Card feat(Card): Add disabled prop Apr 16, 2020
mnajdova
mnajdova approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment inside the styles, other than that looks good.

@pompomon pompomon merged commit 0dedb62 into microsoft:master Apr 17, 2020
DuanShaolong pushed a commit to DuanShaolong/fluentui that referenced this pull request Apr 27, 2020
@pompomon @DuanShaolong
feat(Card): Add disabled prop (microsoft#12743)
fb23c6a 
* Add disabled prop

* Changelog + style updates

* Remove negation in styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@layershifter layershifter Awaiting requested review from layershifter

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

Assignees

@joschect joschect

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pompomon @msft-github-bot @mnajdova @joschect