feat(factories): changed createShorthand signature, to use the optional shorthandConfig static on the component #12783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added shorthandConfig on the Button component -replaced Button.create usages
mnajdova
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 89b53e7f43d70ffac4e9d308428356c90b8ac06b (build) |
mnajdova
commented
Apr 20, 2020
mnajdova
changed the title
pompomon
approved these changes
Apr 20, 2020
silviuaavram
approved these changes
Apr 20, 2020
| @@ -68,7 +69,7 @@ class ButtonGroup extends UIComponent<WithAsProp<ButtonGroupProps>, any> { | |||
| return ( | |||
| <ElementType {...unhandledProps} className={classes.root}> | |||
| {_.map(buttons, (button, idx) => | |||
| Button.create(button, { | |||
| createShorthand<WithAsProp<ButtonProps>>(Button, button, { | |||
There was a problem hiding this comment.
I expect that this will be inferred from the first param
There was a problem hiding this comment.
Make sense, I changed it
-added class component example
mnajdova
changed the title
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
…al shorthandConfig static on the component (microsoft#12783) * -added updated createdShorthand method -added shorthandConfig on the Button component -replaced Button.create usages * -fixed typings * -removed console log * -removed unnecessary undefined * -improved typings -added class component example * -updated changelog
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding updated
createShorthandutility, that based on the staticshorthandConfigon the component, allows user to create react elements from the shorthand. As a showcase it is used on this PR to replace theButton.create,AccordionTitle.createandAccordionContent.createusages (this covers both functional and class components). This will allow us to have more flexible shorthand story, for allowing users to define their own components for the shorthands (this will be required later on on the compose factory).BREAKING CHANGES
The
mappedProp,allowsJSXandmappedArrayPropare expected to be defined as a static shorthandConfig on the component. If it is not defined, this are the defaults:Example: