Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding fluid-avatar icon #12803

Merged
merged 5 commits into from
Apr 24, 2020
Merged

Adding fluid-avatar icon #12803

merged 5 commits into from
Apr 24, 2020

Conversation

TanelVari
Copy link
Contributor

@TanelVari TanelVari commented Apr 22, 2020 •
edited by msft-github-bot

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Apr 22, 2020
@size-auditor
Copy link

size-auditor bot commented Apr 22, 2020 •
edited

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4818ed71e8858d60bfacaef377e1c66d506a99ae (build)

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Apr 22, 2020 •
edited

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 751 785 5000
Checkbox 1387 1401 5000
CheckboxBase 1209 1252 5000
ChoiceGroup 4453 4910 5000
ComboBox 918 836 1000
CommandBar 6549 6081 1000
ContextualMenu 11628 11543 1000
DefaultButton 983 1096 5000
DetailsRow 3105 3316 5000
DetailsRow (fast icons) 2954 3001 5000
DetailsRow without styles 2734 2756 5000
Dialog 1289 1299 1000
DocumentCardTitle with truncation 1364 1365 1000
Dropdown 2276 2320 5000
FocusZone 1301 1313 5000
IconButton 1448 1527 5000
Label 270 240 5000
Link 440 414 5000
MenuButton 1196 1369 5000
Nav 2699 2713 1000
Panel 1280 1227 1000
Persona 722 713 1000
Pivot 1078 1115 1000
PrimaryButton 1135 1038 5000
SearchBox 1130 1161 5000
Slider 1280 1362 5000
Spinner 359 319 5000
SplitButton 2925 2773 5000
Stack 448 479 5000
Stack with Intrinsic children 1032 1029 5000
Stack with Text children 4091 3949 5000
TagPicker 2512 2694 5000
Text 353 320 5000
TextField 1186 1260 5000
Toggle 797 753 5000
button 66 55 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.49 0.45 1.09:1 2000 988
🦄 Button.Fluent 0.1 0.18 0.56:1 5000 511
🔧 Checkbox.Fluent 0.6 0.31 1.94:1 1000 604
🔧 Dialog.Fluent 0.34 0.19 1.79:1 5000 1699
🔧 Dropdown.Fluent 2.87 0.44 6.52:1 1000 2869
🔧 Icon.Fluent 0.15 0.04 3.75:1 5000 732
🎯 Image.Fluent 0.07 0.1 0.7:1 5000 372
🔧 Slider.Fluent 1.17 0.29 4.03:1 1000 1174
🔧 Text.Fluent 0.06 0.02 3:1 5000 311
🦄 Tooltip.Fluent 0.09 13.5 0.01:1 5000 425

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 318 260 1.22:1
ChatDuplicateMessagesPerf.default 438 365 1.2:1
RefMinimalPerf.default 197 166 1.19:1
TreeWith60ListItems.default 237 202 1.17:1
TextMinimalPerf.default 378 325 1.16:1
Tooltip.Fluent 425 371 1.15:1
GridMinimalPerf.default 725 636 1.14:1
StatusMinimalPerf.default 686 600 1.14:1
ImageMinimalPerf.default 357 322 1.11:1
VideoMinimalPerf.default 618 558 1.11:1
RadioGroupMinimalPerf.default 588 541 1.09:1
AvatarMinimalPerf.default 472 437 1.08:1
HeaderSlotsPerf.default 1568 1447 1.08:1
Avatar.Fluent 988 919 1.08:1
AttachmentMinimalPerf.default 137 128 1.07:1
AttachmentSlotsPerf.default 1069 999 1.07:1
Icon.Fluent 732 681 1.07:1
AccordionMinimalPerf.default 205 194 1.06:1
LayoutMinimalPerf.default 533 505 1.06:1
LoaderMinimalPerf.default 692 650 1.06:1
IconMinimalPerf.default 672 631 1.06:1
TextAreaMinimalPerf.default 2483 2351 1.06:1
CardMinimalPerf.default 509 486 1.05:1
CheckboxMinimalPerf.default 2725 2602 1.05:1
ListNestedPerf.default 898 853 1.05:1
PopupMinimalPerf.default 227 217 1.05:1
SliderMinimalPerf.default 1256 1192 1.05:1
Image.Fluent 372 354 1.05:1
AnimationMinimalPerf.default 624 602 1.04:1
ChatWithPopoverPerf.default 532 513 1.04:1
FormMinimalPerf.default 736 709 1.04:1
Button.Fluent 511 491 1.04:1
Dialog.Fluent 1699 1641 1.04:1
BoxMinimalPerf.default 280 273 1.03:1
ChatMinimalPerf.default 599 581 1.03:1
DropdownManyItemsPerf.default 1342 1300 1.03:1
DropdownMinimalPerf.default 3121 3031 1.03:1
ProviderMergeThemesPerf.default 1398 1360 1.03:1
CustomToolbarPrototype.default 3166 3074 1.03:1
Checkbox.Fluent 604 584 1.03:1
ListWith60ListItems.default 1154 1130 1.02:1
MenuButtonMinimalPerf.default 1487 1462 1.02:1
AlertMinimalPerf.default 288 285 1.01:1
HeaderMinimalPerf.default 478 472 1.01:1
PortalMinimalPerf.default 304 300 1.01:1
TableMinimalPerf.default 603 598 1.01:1
TreeMinimalPerf.default 1141 1131 1.01:1
Dropdown.Fluent 2869 2839 1.01:1
CarouselMinimalPerf.default 527 526 1:1
ToolbarMinimalPerf.default 937 936 1:1
ButtonSlotsPerf.default 499 503 0.99:1
TooltipMinimalPerf.default 625 631 0.99:1
DividerMinimalPerf.default 734 751 0.98:1
EmbedMinimalPerf.default 3965 4028 0.98:1
InputMinimalPerf.default 893 907 0.98:1
LabelMinimalPerf.default 372 379 0.98:1
SegmentMinimalPerf.default 941 962 0.98:1
SplitButtonMinimalPerf.default 3206 3300 0.97:1
Text.Fluent 311 319 0.97:1
ItemLayoutMinimalPerf.default 1529 1600 0.96:1
ListCommonPerf.default 826 861 0.96:1
Slider.Fluent 1174 1229 0.96:1
DialogMinimalPerf.default 1575 1653 0.95:1
MenuMinimalPerf.default 1648 1726 0.95:1
ButtonMinimalPerf.default 124 132 0.94:1
HierarchicalTreeMinimalPerf.default 916 977 0.94:1
ListMinimalPerf.default 421 451 0.93:1
ReactionMinimalPerf.default 1844 1997 0.92:1
ProviderMinimalPerf.default 559 627 0.89:1

@mnajdova
Copy link
Contributor

Accept screener differences before merging!

@TanelVari TanelVari closed this Apr 24, 2020
@TanelVari TanelVari reopened this Apr 24, 2020
@TanelVari TanelVari merged commit a0704a2 into microsoft:master Apr 24, 2020
DuanShaolong pushed a commit to DuanShaolong/fluentui that referenced this pull request Apr 27, 2020
@TanelVari @DuanShaolong
Adding fluid-avatar icon (microsoft#12803)
35d107b 
* Adding fluid-avatar icon

* Update CHANGELOG

* Rename file

* Name change in changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@dzearing dzearing Awaiting requested review from dzearing

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@layershifter layershifter Awaiting requested review from layershifter

@levithomason levithomason Awaiting requested review from levithomason

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@pompomon pompomon Awaiting requested review from pompomon

Assignees

@joschect joschect

Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TanelVari @msft-github-bot @mnajdova @joschect