fix(Accordion): Render title as div by default #12840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompomon
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
mnajdova
reviewed
Apr 23, 2020
packages/fluentui/react-northstar/src/components/Accordion/AccordionTitle.tsx
Outdated
Show resolved
Hide resolved
mnajdova
approved these changes
Apr 23, 2020
…ordionTitle.tsx Co-Authored-By: Marija Najdova <mnajdova@gmail.com>
|
Hello @pompomon! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 48 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 2081ac4da8b1a4f37483a1a653fca74dd3ed9e12 (build) |
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
#### Pull request checklist - [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` #### Description of changes Fix accordion title to be rendered as `div` instead of `span`
8 tasks
miroslavstastny
pushed a commit
that referenced
this pull request
May 13, 2020
- [ ] Addresses an existing issue: Fixes #0000 - [ ] Include a change request file using `$ yarn change` Fix accordion title to be rendered as `div` instead of `span` (cherry picked from commit 4818ed7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Fix accordion title to be rendered as
divinstead ofspanMicrosoft Reviewers: Open in CodeFlow