docs(Toolbar): accessibility polish - testing preparation #12884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 25 commits
April 3, 2020 14:52
kolaps33
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter and
levithomason
as code owners
mnajdova
reviewed
Apr 30, 2020
| return ( | ||
| <Toolbar | ||
| aria-label="Toolbar can contain a radio group in a menu" | ||
| items={[ | ||
| toolbarItem('underline', <UnderlineIcon />), |
There was a problem hiding this comment.
nit: To be honest, I would just spread objects here. From client's perspective it's much easier to just go trough the items object, instead of seeing what the function that is invoked is doing...
There was a problem hiding this comment.
Would be much more readable :)
mnajdova
reviewed
Apr 30, 2020
...ages/fluentui/docs/src/examples/components/Toolbar/Content/ToolbarExamplePopup.shorthand.tsx
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Apr 30, 2020
| description="Toolbar item can open a menu which can contain radio groups." | ||
| examplePath="components/Toolbar/Content/ToolbarExampleMenuRadioGroup" | ||
| /> | ||
| <ComponentExample | ||
| title="Toolbar can contain a submenu in a menu" | ||
| toolbarAriaLabel="Example Toolbar can contain a submenu in a menu" |
There was a problem hiding this comment.
Shuoldn't this be removed?
There was a problem hiding this comment.
good catch thank you :)
mnajdova
reviewed
Apr 30, 2020
| @@ -7,6 +7,7 @@ const Performance = () => ( | |||
| <ExampleSection title="Performance"> | |||
| <ComponentPerfExample | |||
| title="Custom styled" | |||
| toolbarAriaLabel="Example performance" | |||
There was a problem hiding this comment.
good catch thank you :)
…/ToolbarExamplePopup.shorthand.tsx commit based on Marija comment Co-Authored-By: Marija Najdova <mnajdova@gmail.com>
…kolaps33/office-ui-fabric-react into mituron/acc-testing-preparation
mnajdova
approved these changes
Apr 30, 2020
added 14 commits
April 30, 2020 15:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In order to give Toolbar component for testing, we should be consistent with ARIA.
https://www.w3.org/TR/wai-aria-practices-1.2/#toolbar
Apply following:
and from role "Toolbar" itself
https://www.w3.org/TR/wai-aria-1.2/#toolbar
Apply following:
In order to fulfill these requirements above:
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow