Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(DropdownSearchInput): Convert to RFC #12978

Conversation

assuncaocharles
Copy link
Contributor

@assuncaocharles assuncaocharles commented May 2, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

BREAKING CHANGES

This PR converts DropdownSearchInput component to be functional. Restricting props set that will be passed to styles functions.

Related to #12237

Prop sets

DropdownSearchInput
inline

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 2, 2020

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 779 796 5000
Checkbox 1489 1543 5000
CheckboxBase 1283 1305 5000
ChoiceGroup 4928 4942 5000
ComboBox 965 895 1000
CommandBar 6829 7026 1000
ContextualMenu 13622 12601 1000
DefaultButton 1060 1048 5000
DetailsRow 3282 3265 5000
DetailsRow (fast icons) 3362 3362 5000
DetailsRow without styles 3035 3168 5000
Dialog 1449 1477 1000
DocumentCardTitle with truncation 1467 1469 1000
Dropdown 2441 2409 5000
FocusZone 1561 1532 5000
IconButton 1685 1700 5000
Label 307 299 5000
Link 445 459 5000
MenuButton 1418 1426 5000
Nav 3055 3008 1000
Panel 1382 1468 1000
Persona 835 834 1000
Pivot 1293 1293 1000
PrimaryButton 1232 1209 5000
SearchBox 1267 1286 5000
Slider 1499 1496 5000
Spinner 352 345 5000
SplitButton 2948 3016 5000
Stack 465 473 5000
Stack with Intrinsic children 1119 1108 5000
Stack with Text children 4210 4158 5000
TagPicker 2728 2901 5000
Text 388 390 5000
TextField 1362 1431 5000
Toggle 862 865 5000
button 55 72 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.49 0.47 1.04:1 2000 974
🦄 Button.Fluent 0.11 0.19 0.58:1 5000 563
🔧 Checkbox.Fluent 0.61 0.32 1.91:1 1000 609
🔧 Dialog.Fluent 0.35 0.2 1.75:1 5000 1738
🔧 Dropdown.Fluent 3.09 0.42 7.36:1 1000 3087
🔧 Icon.Fluent 0.15 0.05 3:1 5000 749
🎯 Image.Fluent 0.08 0.1 0.8:1 5000 375
🔧 Slider.Fluent 1.33 0.34 3.91:1 1000 1329
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 354
🦄 Tooltip.Fluent 0.09 15.32 0.01:1 5000 437

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TextMinimalPerf.default 381 317 1.2:1
InputMinimalPerf.default 955 898 1.06:1
ListWith60ListItems.default 1140 1078 1.06:1
ToolbarMinimalPerf.default 1080 1022 1.06:1
TooltipMinimalPerf.default 719 676 1.06:1
TreeMinimalPerf.default 1282 1205 1.06:1
AnimationMinimalPerf.default 660 630 1.05:1
AttachmentSlotsPerf.default 1114 1061 1.05:1
MenuButtonMinimalPerf.default 1623 1547 1.05:1
ProviderMinimalPerf.default 627 595 1.05:1
RefMinimalPerf.default 194 184 1.05:1
Slider.Fluent 1329 1262 1.05:1
HeaderSlotsPerf.default 1588 1533 1.04:1
ImageMinimalPerf.default 382 368 1.04:1
ItemLayoutMinimalPerf.default 1712 1648 1.04:1
TableMinimalPerf.default 417 401 1.04:1
Text.Fluent 354 341 1.04:1
ChatWithPopoverPerf.default 563 547 1.03:1
DropdownMinimalPerf.default 3110 3014 1.03:1
HeaderMinimalPerf.default 522 507 1.03:1
LoaderMinimalPerf.default 773 753 1.03:1
PopupMinimalPerf.default 235 229 1.03:1
VideoMinimalPerf.default 639 618 1.03:1
Icon.Fluent 749 724 1.03:1
Tooltip.Fluent 437 425 1.03:1
DropdownManyItemsPerf.default 1337 1306 1.02:1
FlexMinimalPerf.default 279 273 1.02:1
ProviderMergeThemesPerf.default 1563 1531 1.02:1
TreeWith60ListItems.default 222 217 1.02:1
AttachmentMinimalPerf.default 146 144 1.01:1
CarouselMinimalPerf.default 565 561 1.01:1
ChatMinimalPerf.default 621 614 1.01:1
ListCommonPerf.default 955 942 1.01:1
PortalMinimalPerf.default 310 307 1.01:1
SegmentMinimalPerf.default 922 917 1.01:1
Avatar.Fluent 974 967 1.01:1
Button.Fluent 563 555 1.01:1
AvatarMinimalPerf.default 494 495 1:1
ChatDuplicateMessagesPerf.default 391 392 1:1
FormMinimalPerf.default 783 781 1:1
HierarchicalTreeMinimalPerf.default 1024 1025 1:1
ListMinimalPerf.default 463 463 1:1
MenuMinimalPerf.default 1833 1841 1:1
SplitButtonMinimalPerf.default 3285 3276 1:1
StatusMinimalPerf.default 680 680 1:1
TextAreaMinimalPerf.default 507 505 1:1
CustomToolbarPrototype.default 3417 3432 1:1
Checkbox.Fluent 609 611 1:1
BoxMinimalPerf.default 320 323 0.99:1
CheckboxMinimalPerf.default 2795 2820 0.99:1
DialogMinimalPerf.default 1733 1757 0.99:1
GridMinimalPerf.default 699 706 0.99:1
ReactionMinimalPerf.default 1881 1891 0.99:1
SliderMinimalPerf.default 1307 1314 0.99:1
Dialog.Fluent 1738 1755 0.99:1
Dropdown.Fluent 3087 3125 0.99:1
LabelMinimalPerf.default 391 397 0.98:1
ListNestedPerf.default 899 915 0.98:1
RadioGroupMinimalPerf.default 612 626 0.98:1
Image.Fluent 375 382 0.98:1
AlertMinimalPerf.default 298 307 0.97:1
DividerMinimalPerf.default 764 784 0.97:1
ButtonSlotsPerf.default 574 597 0.96:1
IconMinimalPerf.default 659 689 0.96:1
LayoutMinimalPerf.default 546 575 0.95:1
ButtonMinimalPerf.default 150 160 0.94:1
CardMinimalPerf.default 546 589 0.93:1
EmbedMinimalPerf.default 1899 2034 0.93:1
AccordionMinimalPerf.default 129 146 0.88:1

@size-auditor
Copy link

size-auditor bot commented May 2, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5ded02cceddcaf0e2274187e58cc9ee8ff9a79a9 (build)

@assuncaocharles assuncaocharles merged commit b2ce086 into microsoft:master May 4, 2020
@assuncaocharles assuncaocharles deleted the chore/dropdown-search-input-rfc branch May 4, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants