#196739: updated icon button styles per design specs #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 22, 2016 13:12
- removed gapSpace settings in the examples as they can use the default.
|
Hi @dubunin, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| .ms-Button-icon { | ||
| display: inline; | ||
| } | ||
| &.is-disabled, &:disabled { |
There was a problem hiding this comment.
nit: newline before block declarations
|
Approved 🍊 With small stylistic suggestions. Looks great! |
| background-color: transparent; | ||
| border-color: transparent; | ||
| outline-color: transparent; | ||
| color: $ms-color-neutralPrimary; | ||
| } |
There was a problem hiding this comment.
Please verify this still looks like a button or how you'd expect in high contrast.
There was a problem hiding this comment.
Double checked with design to make sure this is the desired look. Also, worked with design to figure out high contrast colors for icon buttons. Decided best to use colors that match up with link colors in high contrast. Per design no hover color change necessary in high contrast. Cursor changing to pointer is change enough.
Dubunin/callout issues
Bringing over the latest updates from separate VSO repo.
Fixing list group header css
…ceDev/office-ui-fabric-react into dubunin/icon-button-styling
|
@dubunin, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
atneik
added a commit
that referenced
this pull request
Aug 1, 2016
* Fixing list group header css * Fix infinity loop when this.props.getItemCountForPage return 0 as item count per page. (#22) Fix infinity loop when this.props.getItemCountForPage return 0 * Dubunin/breadcrumb issues (#12) * #191731: updated hover state color for overflow button * #191719: added override styles for breadcrumb focus rect * #191719: code formatting - missing space * #191723: per design - removed negative margin-right from overflow breadcrumb * #191723: code cleanup * #191723: updated to use localized margins * 191731: removed overrides that are no longer necessary. Updated to use focus-border. * Added null check to root search for withViewport Added null check to root search for withViewport * DetailsList now resets columns correctly when they change based on new items passed in (#26) * Adding repo example. * Fixing the filter bug * Adding 2 more reviewers. * Adding travis file. * rename temporarily. * Renaming back. * Rename. * Renaming. * Applying an undo of the recent Nav changes until we sort out the correct fix (#27) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * v0.36.0 (#28) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * Make detailslist not render groupedList if no grouping information Make detailslist not render groupedList if no grouping information * #196739: updated icon button styles per design specs (#13) * #196743: removed beakWidth and class settings. Use defaults * TaskID 196744: updated default gapSpace to be 16 - removed gapSpace settings in the examples as they can use the default. * #196739: updated icon button styles per design specs * Fixing list group header css * Bringing over the latest updates from separat VSO repo. * Replacing tabs with spaces. * Adding example and bestpractices. * Removing examples from npm publishing. (#19) * 196739: code cleanup and contrast styles * #196739: updated icon button styles per design specs * 196739: code cleanup and contrast styles * Minor fix for viewport decorator to avoid rendering content in 0 space. (#29) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * Minor tweak to viewport decorator to not render content in 0 width/height cases and also to avoid nullrefing in this situation when forceUpdate is called. * Updating details row fields to cache less to ensure forceUpdates work correctly. * Fixing the build to default to production. * v0.36.1 (#33) * 0.36.2 - Fix errant imports (#34) * Fix errant imports * Bump package.json as well * Fixed detailsList onRowDidMount callback (#37) * Updating icons to MDL2 * One more
atneik
added a commit
that referenced
this pull request
Sep 7, 2016
* init. building * adding more component states * removing last reminiscent of 2.6 * [MDL2]: Breadcrumb, fixing the branch (#30) * Fixing list group header css * Fix infinity loop when this.props.getItemCountForPage return 0 as item count per page. (#22) Fix infinity loop when this.props.getItemCountForPage return 0 * Dubunin/breadcrumb issues (#12) * #191731: updated hover state color for overflow button * #191719: added override styles for breadcrumb focus rect * #191719: code formatting - missing space * #191723: per design - removed negative margin-right from overflow breadcrumb * #191723: code cleanup * #191723: updated to use localized margins * 191731: removed overrides that are no longer necessary. Updated to use focus-border. * Added null check to root search for withViewport Added null check to root search for withViewport * Updating Icons, cleaning SCSS * DetailsList now resets columns correctly when they change based on new items passed in (#26) * Adding repo example. * Fixing the filter bug * Adding 2 more reviewers. * Adding travis file. * rename temporarily. * Renaming back. * Rename. * Renaming. * Applying an undo of the recent Nav changes until we sort out the correct fix (#27) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * v0.36.0 (#28) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * Using semantic variables * fixing date picker fonts * fixing font in details header * more font fixes * making overflow button 16px * [MDL2]: Updating icons (#39) * Fixing list group header css * Fix infinity loop when this.props.getItemCountForPage return 0 as item count per page. (#22) Fix infinity loop when this.props.getItemCountForPage return 0 * Dubunin/breadcrumb issues (#12) * #191731: updated hover state color for overflow button * #191719: added override styles for breadcrumb focus rect * #191719: code formatting - missing space * #191723: per design - removed negative margin-right from overflow breadcrumb * #191723: code cleanup * #191723: updated to use localized margins * 191731: removed overrides that are no longer necessary. Updated to use focus-border. * Added null check to root search for withViewport Added null check to root search for withViewport * DetailsList now resets columns correctly when they change based on new items passed in (#26) * Adding repo example. * Fixing the filter bug * Adding 2 more reviewers. * Adding travis file. * rename temporarily. * Renaming back. * Rename. * Renaming. * Applying an undo of the recent Nav changes until we sort out the correct fix (#27) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * v0.36.0 (#28) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * Make detailslist not render groupedList if no grouping information Make detailslist not render groupedList if no grouping information * #196739: updated icon button styles per design specs (#13) * #196743: removed beakWidth and class settings. Use defaults * TaskID 196744: updated default gapSpace to be 16 - removed gapSpace settings in the examples as they can use the default. * #196739: updated icon button styles per design specs * Fixing list group header css * Bringing over the latest updates from separat VSO repo. * Replacing tabs with spaces. * Adding example and bestpractices. * Removing examples from npm publishing. (#19) * 196739: code cleanup and contrast styles * #196739: updated icon button styles per design specs * 196739: code cleanup and contrast styles * Minor fix for viewport decorator to avoid rendering content in 0 space. (#29) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * Minor tweak to viewport decorator to not render content in 0 width/height cases and also to avoid nullrefing in this situation when forceUpdate is called. * Updating details row fields to cache less to ensure forceUpdates work correctly. * Fixing the build to default to production. * v0.36.1 (#33) * 0.36.2 - Fix errant imports (#34) * Fix errant imports * Bump package.json as well * Fixed detailsList onRowDidMount callback (#37) * Updating icons to MDL2 * One more * [MDL2]: Checkbox & ChoiceGroup (#45) * ChoiceField to Checkbox * fixing focus, rtl, added example * Fixing tslint errors * Fixing styles for choiceField * Adding in-focus state, image choice field clean up * fixing focus() * Tslint errors * Adding role to children of ChoiceGroup * Removing unnecessary attributes, addressing comments, whitespace * #218302: updated keyboard focus styles for pivot links and pivot tab … (#48) * #218302: updated keyboard focus styles for pivot links and pivot tab links. * #218302: localized margin-right * [MDL2]: Dialog, Overlay fixes (#52) * init * Getting rid of z-index * Rid of sibling selector * Using Button component for Close button * Using semantic variables, fixing close callback * Addressing comments * Fix alignment, Icon. consolidate overrides (#61) * #225536: added support for item count on link style pivots. Added Piv… (#51) * #225536: added support for item count on link style pivots. Added Pivot.ItemCount.Example. * #225536: updated spacing and text styles for pivot itemCount * 225536: updated spacing and text styles for pivot itemCount * #225536: updates per feedback. * #225536: removed font-weight change for itemCount text * #225536: fixed title case * [MDL2]: ContextualMenu (#63) * Update example icons, change selected item bg * aligning icons * Fix example * Using semantic variables * Updating to fabric-core * Fixing icons Fabric-core now doesn’t set ‘line-height: 1’ on Icons * Dubunin/beta mdl2/messagebar updates (#92) * #225406: cleaned up messageBar overrides. * #225406: updated messageBar styles per redlines. * #225406: nit code formatting * #225406: nit - updated selector name * fixing the example, high contrast issues, trimming (#75) * [MDL2]: Dropdown and ContextualMenu style updates (#85) * dropdown color updates, and focusBorder color update * Removing icons from check example, setting item height to 36px * hover color update, focus bg * Addressing comments Newline Cursor pointer in ContextualMenu * [MDL2]: CommandBar style updates. Fabric extra colors not needed; theme overrides fixed. (#104) * Init. Updating default styles and padding. * Using padding instead of margin This is to get overflow items calculated correctly * fixing overflow calculations * Increase target area when Icons only * fixing searchBar * Removing fabric extra colors, fixing neutral Quaternary color. CommandBar item state styles * remove Alpha state * #225405: refactored override styles (#90) * #225405: refactored override styles * #225405: removed BUTTON.ms-link class * Remove changes to Facepile, PeoplePicker, Persona. Checkbox left padding removed * Merge branch 'master' into beta/mdl2 * Removing updates from Check, SearchBox * Fixing Checkbox for defaultChecked * Updates to SearchBox component to match 3.0.0 styles * Updates to SearchBox component to match fabric js 3.0.0 styles * Update styles on SearchBox, remove overrides, change icon from Cancel to Clear on component * Fix no trailing white-space lint error on SearchBox.tsx * Update PeoplePicker and TextField styles * Update Panel close button font-size * Update people picker padding/spacing * Remove ms-TextField--placeholder variant css (unused in Fabric React), and add ms-baseFont to ms-TextField-field to fix font-family * Change SearchBox padding-left to 3px; * Update persona overrides * Updated calendar glyph. Adusted heights, widths and positions. * modified chevron for small screen size. * Fixing broken build. * style tweaks, replaced hard coded value with variable. * changed height of button. * Update to fabric-core ver * Updating Tag icon, and size * #239194: fixed styles that were causing the out transition to not position properly (#168) * Update Persona styles, add mdl2 Skype icons, add "busy" as persona example, fix typo with secondary in Persona examples.tsx * Changing Add icon. Reducing padding in Dialog close button * Added icon to hero button variant. * remove unused variants from Persona sass * Removed unused and repetitive styles. Aligned styles to MDL2. * Remove place kitten from DetailsList marquee selection * Updated remove variant to blocked. Updated icons. Fixed ellipses truncation. * removed border in active state for hero button. * Merge master into 'Beta/mdl2' (#182) * Updating the group-by icon * Added initial focus to callout * changed focus method to be more clear. Added more jsdoc comments * Update .pullapprove.yml (#166) * Update .pullapprove.yml * Update .pullapprove.yml * Update .pullapprove.yml * Adding focus to command bar contract. (#165) * SelectionZone: adding a ton of unit tests and fine tuning all the edge cases (#172) * Allowing specific elements to immediately invoke the item. * Addding tests. * Adding significantly more unit test coverage. * Updates to docs. * Removing unnecessary change. * Updating detailslist basic example with correct selection example. * v0.45.0 (#173) * Make DocumentCardAction props extend from Button props. This will make sure we can set all the properties on the action button such as aria label. (#170) * Make DocumentCardAction props extend from Button props. This will make sure we can set all the properties on the action button such as aria label. * Add missing semicolon * remove IDocumentCardAction interface since we actually only need button props. * Update .pullapprove.yml (#180) * Add RTL support for PeoplePicker/Persona/SearchBox * Bug 239872:Fabric React MDL2 Bug: Link: Capitalize "i" in "i am a link without an href" * Bug 239821:Fabric React MDL2 Bug: Persona: Shadow/outline around circles * Bug 239881:Fabric React MDL2 Bug: Facepile: Personas rotated on edge Bug 239818:Fabric React MDL2 Bug: Facepile - Faces don't show up Bug 239892:Fabric React MDL2 Bug: Persona: Unchecking "Include persona details" removes persona images * Bug 239882:Fabric React MDL2 Bug: Slider: active sliding theme color * Bug 239877:Fabric React MDL2 Bug: TextField: Button next to TextField in example is misaligned * Bug 239807:Fabric React MDL2 Bug: TextField: Label font weights are incorrect * Bug 239890:Fabric React MDL2 Bug: TextField: Font weights and colors are different between single and multiline textfields * Change logic in Persona to always show persona details for tiny * Replace personas in DocumentCard * Change to MDL2 icons in DocumentCard example * Small bug fixes in Persona, remove white space, change == to === * Adjusted position of expand icon for MDL2. * MDL2: ContextualMenu styling bugs (#191) * Updating the group-by icon * Added initial focus to callout * changed focus method to be more clear. Added more jsdoc comments * Update .pullapprove.yml (#166) * Update .pullapprove.yml * Update .pullapprove.yml * Update .pullapprove.yml * Adding focus to command bar contract. (#165) * SelectionZone: adding a ton of unit tests and fine tuning all the edge cases (#172) * Allowing specific elements to immediately invoke the item. * Addding tests. * Adding significantly more unit test coverage. * Updates to docs. * Removing unnecessary change. * Updating detailslist basic example with correct selection example. * v0.45.0 (#173) * Make DocumentCardAction props extend from Button props. This will make sure we can set all the properties on the action button such as aria label. (#170) * Make DocumentCardAction props extend from Button props. This will make sure we can set all the properties on the action button such as aria label. * Add missing semicolon * remove IDocumentCardAction interface since we actually only need button props. * Update .pullapprove.yml (#180) * Fixing extra on left of contextualMenu icon and also size of right chevron * Charms cursor pointed; and 40px sqs * Fixed DatePicker bugs, Removed unused float. * Fixed hero button spacing. * Persona details fix, remove avatar-josh/kat * ChoiceGroup: Centering the initial position of inner circle. (#200) * Fixed clear button. Updated styles. * Changed create site button icon. * Fixed position of eye icon. * replaced double quotes with single quotes. * MDL2: Checkbox - high contrast issues (#204) * fixing high contrast issue * fixing in-focus border * renaming * centering * Fixed padding issue and close button positioning. * #239886: removed is-selected style for large pivots as it was wrong and unecessary. (#207) * MDL2: Peoplepicker RTL and style fixes (#208) * Centering the X button, and fixing hover styling issues * Fixing hover spacing issue, RTL issues * repeat class bug fix * Add SortUp and SortDown icons to _fabricExtraIcons and change DetailsHeader.tsx to include new icons (#210) * Typo fix * Fix bug 239894 and 239885. Remove scroll bar when dropdown shows 1-3 people, fix item height under 480px breakpoint. * MDL2: Fabric-core ver bump (#214) * Depending upon fabric-core 4.0.0, adding neutralPrimary color * Remove extra icons file Fabric-core added 400+ icon classes * added support for deprecated remove value * fixing gulpfile * New MDL2 check, switched from SVG circle to css * Remove z-index from check and check background * Fix border radius on people picker persona component. * Change color of remove button to neutral primary and add border-radius to fix button hover * MDL2: Checkbox, ChoiceField fixes. Merge master (#244) * Persona: now renders children within the details, and overflow on details removed (#215) * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * resolve comments * resolve comments * Minor changes. * Adding @autoBind usage to a number of the components. (#233) * Updating GroupedList, Link, MarqueeSelection, Breadcrumb, Toggle, Callout * Updating autobinds for Checkbox, ColorPicker, CommandBar, ContextualMenu. * Updating SelectionZone autobinds. * Adding autobind to Utilities export. * Adding best practice notes. * Updating autobind for FocusZone. * Removing dead code. * DatePicker: Change text input validation to only call onSelectDate when text input is allowed (#230) * Fixed validation when allowTextInput is false * Fixed formatting * Update package.json * Dropdown: isDisabled is respected when the value changes. (#237) * v0.47.2 * Using react events * Fixing a minor bug in selection where isAllSelected is returning true when all items are unselectable. Added test, validated the fix works. (#240) * BaseComponent: Adding a _resolveRef helper to create memoized helpers to resolve refs. (#238) * Adding a _resolveRef helper to create memoized helpers to resolve refs. * Cleaning up tslint. * v0.47.3 * ContextualMenu: added tooltip and arialabel to menu and menu items. (#241) * v0.48.0 * Using css utility map * Use @autoBind and _resolveRef * Adding focus state * Adding isChecked state * Removing unneeded variables * ChoiceGroup using react events * Fixing type * MDL2: RTL and other fixes (#255) * Un-nesting CSS * Dropdown more consistent * Persona RTL fixes * RTL fixes * nit fixes * Removing Pivot item count example
gokunymbus
pushed a commit
to gokunymbus/office-ui-fabric-react
that referenced
this pull request
Jan 24, 2017
* #196743: removed beakWidth and class settings. Use defaults * TaskID 196744: updated default gapSpace to be 16 - removed gapSpace settings in the examples as they can use the default. * #196739: updated icon button styles per design specs * Fixing list group header css * Bringing over the latest updates from separat VSO repo. * Replacing tabs with spaces. * Adding example and bestpractices. * Removing examples from npm publishing. (microsoft#19) * 196739: code cleanup and contrast styles * #196739: updated icon button styles per design specs * 196739: code cleanup and contrast styles
gokunymbus
pushed a commit
to gokunymbus/office-ui-fabric-react
that referenced
this pull request
Jan 24, 2017
* init. building * adding more component states * removing last reminiscent of 2.6 * [MDL2]: Breadcrumb, fixing the branch (microsoft#30) * Fixing list group header css * Fix infinity loop when this.props.getItemCountForPage return 0 as item count per page. (microsoft#22) Fix infinity loop when this.props.getItemCountForPage return 0 * Dubunin/breadcrumb issues (microsoft#12) * #191731: updated hover state color for overflow button * #191719: added override styles for breadcrumb focus rect * #191719: code formatting - missing space * #191723: per design - removed negative margin-right from overflow breadcrumb * #191723: code cleanup * #191723: updated to use localized margins * 191731: removed overrides that are no longer necessary. Updated to use focus-border. * Added null check to root search for withViewport Added null check to root search for withViewport * Updating Icons, cleaning SCSS * DetailsList now resets columns correctly when they change based on new items passed in (microsoft#26) * Adding repo example. * Fixing the filter bug * Adding 2 more reviewers. * Adding travis file. * rename temporarily. * Renaming back. * Rename. * Renaming. * Applying an undo of the recent Nav changes until we sort out the correct fix (microsoft#27) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * v0.36.0 (microsoft#28) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * Using semantic variables * fixing date picker fonts * fixing font in details header * more font fixes * making overflow button 16px * [MDL2]: Updating icons (microsoft#39) * Fixing list group header css * Fix infinity loop when this.props.getItemCountForPage return 0 as item count per page. (microsoft#22) Fix infinity loop when this.props.getItemCountForPage return 0 * Dubunin/breadcrumb issues (microsoft#12) * #191731: updated hover state color for overflow button * #191719: added override styles for breadcrumb focus rect * #191719: code formatting - missing space * #191723: per design - removed negative margin-right from overflow breadcrumb * #191723: code cleanup * #191723: updated to use localized margins * 191731: removed overrides that are no longer necessary. Updated to use focus-border. * Added null check to root search for withViewport Added null check to root search for withViewport * DetailsList now resets columns correctly when they change based on new items passed in (microsoft#26) * Adding repo example. * Fixing the filter bug * Adding 2 more reviewers. * Adding travis file. * rename temporarily. * Renaming back. * Rename. * Renaming. * Applying an undo of the recent Nav changes until we sort out the correct fix (microsoft#27) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * v0.36.0 (microsoft#28) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * Make detailslist not render groupedList if no grouping information Make detailslist not render groupedList if no grouping information * #196739: updated icon button styles per design specs (microsoft#13) * #196743: removed beakWidth and class settings. Use defaults * TaskID 196744: updated default gapSpace to be 16 - removed gapSpace settings in the examples as they can use the default. * #196739: updated icon button styles per design specs * Fixing list group header css * Bringing over the latest updates from separat VSO repo. * Replacing tabs with spaces. * Adding example and bestpractices. * Removing examples from npm publishing. (microsoft#19) * 196739: code cleanup and contrast styles * #196739: updated icon button styles per design specs * 196739: code cleanup and contrast styles * Minor fix for viewport decorator to avoid rendering content in 0 space. (microsoft#29) * Applying an undo of the recent Nav changes until we sort out the correct fix. * Adding anton as a PR approver. * Minor tweak to viewport decorator to not render content in 0 width/height cases and also to avoid nullrefing in this situation when forceUpdate is called. * Updating details row fields to cache less to ensure forceUpdates work correctly. * Fixing the build to default to production. * v0.36.1 (microsoft#33) * 0.36.2 - Fix errant imports (microsoft#34) * Fix errant imports * Bump package.json as well * Fixed detailsList onRowDidMount callback (microsoft#37) * Updating icons to MDL2 * One more * [MDL2]: Checkbox & ChoiceGroup (microsoft#45) * ChoiceField to Checkbox * fixing focus, rtl, added example * Fixing tslint errors * Fixing styles for choiceField * Adding in-focus state, image choice field clean up * fixing focus() * Tslint errors * Adding role to children of ChoiceGroup * Removing unnecessary attributes, addressing comments, whitespace * #218302: updated keyboard focus styles for pivot links and pivot tab … (microsoft#48) * #218302: updated keyboard focus styles for pivot links and pivot tab links. * #218302: localized margin-right * [MDL2]: Dialog, Overlay fixes (microsoft#52) * init * Getting rid of z-index * Rid of sibling selector * Using Button component for Close button * Using semantic variables, fixing close callback * Addressing comments * Fix alignment, Icon. consolidate overrides (microsoft#61) * #225536: added support for item count on link style pivots. Added Piv… (microsoft#51) * #225536: added support for item count on link style pivots. Added Pivot.ItemCount.Example. * #225536: updated spacing and text styles for pivot itemCount * 225536: updated spacing and text styles for pivot itemCount * #225536: updates per feedback. * #225536: removed font-weight change for itemCount text * #225536: fixed title case * [MDL2]: ContextualMenu (microsoft#63) * Update example icons, change selected item bg * aligning icons * Fix example * Using semantic variables * Updating to fabric-core * Fixing icons Fabric-core now doesn’t set ‘line-height: 1’ on Icons * Dubunin/beta mdl2/messagebar updates (microsoft#92) * #225406: cleaned up messageBar overrides. * #225406: updated messageBar styles per redlines. * #225406: nit code formatting * #225406: nit - updated selector name * fixing the example, high contrast issues, trimming (microsoft#75) * [MDL2]: Dropdown and ContextualMenu style updates (microsoft#85) * dropdown color updates, and focusBorder color update * Removing icons from check example, setting item height to 36px * hover color update, focus bg * Addressing comments Newline Cursor pointer in ContextualMenu * [MDL2]: CommandBar style updates. Fabric extra colors not needed; theme overrides fixed. (microsoft#104) * Init. Updating default styles and padding. * Using padding instead of margin This is to get overflow items calculated correctly * fixing overflow calculations * Increase target area when Icons only * fixing searchBar * Removing fabric extra colors, fixing neutral Quaternary color. CommandBar item state styles * remove Alpha state * #225405: refactored override styles (microsoft#90) * #225405: refactored override styles * #225405: removed BUTTON.ms-link class * Remove changes to Facepile, PeoplePicker, Persona. Checkbox left padding removed * Merge branch 'master' into beta/mdl2 * Removing updates from Check, SearchBox * Fixing Checkbox for defaultChecked * Updates to SearchBox component to match 3.0.0 styles * Updates to SearchBox component to match fabric js 3.0.0 styles * Update styles on SearchBox, remove overrides, change icon from Cancel to Clear on component * Fix no trailing white-space lint error on SearchBox.tsx * Update PeoplePicker and TextField styles * Update Panel close button font-size * Update people picker padding/spacing * Remove ms-TextField--placeholder variant css (unused in Fabric React), and add ms-baseFont to ms-TextField-field to fix font-family * Change SearchBox padding-left to 3px; * Update persona overrides * Updated calendar glyph. Adusted heights, widths and positions. * modified chevron for small screen size. * Fixing broken build. * style tweaks, replaced hard coded value with variable. * changed height of button. * Update to fabric-core ver * Updating Tag icon, and size * #239194: fixed styles that were causing the out transition to not position properly (microsoft#168) * Update Persona styles, add mdl2 Skype icons, add "busy" as persona example, fix typo with secondary in Persona examples.tsx * Changing Add icon. Reducing padding in Dialog close button * Added icon to hero button variant. * remove unused variants from Persona sass * Removed unused and repetitive styles. Aligned styles to MDL2. * Remove place kitten from DetailsList marquee selection * Updated remove variant to blocked. Updated icons. Fixed ellipses truncation. * removed border in active state for hero button. * Merge master into 'Beta/mdl2' (microsoft#182) * Updating the group-by icon * Added initial focus to callout * changed focus method to be more clear. Added more jsdoc comments * Update .pullapprove.yml (microsoft#166) * Update .pullapprove.yml * Update .pullapprove.yml * Update .pullapprove.yml * Adding focus to command bar contract. (microsoft#165) * SelectionZone: adding a ton of unit tests and fine tuning all the edge cases (microsoft#172) * Allowing specific elements to immediately invoke the item. * Addding tests. * Adding significantly more unit test coverage. * Updates to docs. * Removing unnecessary change. * Updating detailslist basic example with correct selection example. * v0.45.0 (microsoft#173) * Make DocumentCardAction props extend from Button props. This will make sure we can set all the properties on the action button such as aria label. (microsoft#170) * Make DocumentCardAction props extend from Button props. This will make sure we can set all the properties on the action button such as aria label. * Add missing semicolon * remove IDocumentCardAction interface since we actually only need button props. * Update .pullapprove.yml (microsoft#180) * Add RTL support for PeoplePicker/Persona/SearchBox * Bug 239872:Fabric React MDL2 Bug: Link: Capitalize "i" in "i am a link without an href" * Bug 239821:Fabric React MDL2 Bug: Persona: Shadow/outline around circles * Bug 239881:Fabric React MDL2 Bug: Facepile: Personas rotated on edge Bug 239818:Fabric React MDL2 Bug: Facepile - Faces don't show up Bug 239892:Fabric React MDL2 Bug: Persona: Unchecking "Include persona details" removes persona images * Bug 239882:Fabric React MDL2 Bug: Slider: active sliding theme color * Bug 239877:Fabric React MDL2 Bug: TextField: Button next to TextField in example is misaligned * Bug 239807:Fabric React MDL2 Bug: TextField: Label font weights are incorrect * Bug 239890:Fabric React MDL2 Bug: TextField: Font weights and colors are different between single and multiline textfields * Change logic in Persona to always show persona details for tiny * Replace personas in DocumentCard * Change to MDL2 icons in DocumentCard example * Small bug fixes in Persona, remove white space, change == to === * Adjusted position of expand icon for MDL2. * MDL2: ContextualMenu styling bugs (microsoft#191) * Updating the group-by icon * Added initial focus to callout * changed focus method to be more clear. Added more jsdoc comments * Update .pullapprove.yml (microsoft#166) * Update .pullapprove.yml * Update .pullapprove.yml * Update .pullapprove.yml * Adding focus to command bar contract. (microsoft#165) * SelectionZone: adding a ton of unit tests and fine tuning all the edge cases (microsoft#172) * Allowing specific elements to immediately invoke the item. * Addding tests. * Adding significantly more unit test coverage. * Updates to docs. * Removing unnecessary change. * Updating detailslist basic example with correct selection example. * v0.45.0 (microsoft#173) * Make DocumentCardAction props extend from Button props. This will make sure we can set all the properties on the action button such as aria label. (microsoft#170) * Make DocumentCardAction props extend from Button props. This will make sure we can set all the properties on the action button such as aria label. * Add missing semicolon * remove IDocumentCardAction interface since we actually only need button props. * Update .pullapprove.yml (microsoft#180) * Fixing extra on left of contextualMenu icon and also size of right chevron * Charms cursor pointed; and 40px sqs * Fixed DatePicker bugs, Removed unused float. * Fixed hero button spacing. * Persona details fix, remove avatar-josh/kat * ChoiceGroup: Centering the initial position of inner circle. (microsoft#200) * Fixed clear button. Updated styles. * Changed create site button icon. * Fixed position of eye icon. * replaced double quotes with single quotes. * MDL2: Checkbox - high contrast issues (microsoft#204) * fixing high contrast issue * fixing in-focus border * renaming * centering * Fixed padding issue and close button positioning. * #239886: removed is-selected style for large pivots as it was wrong and unecessary. (microsoft#207) * MDL2: Peoplepicker RTL and style fixes (microsoft#208) * Centering the X button, and fixing hover styling issues * Fixing hover spacing issue, RTL issues * repeat class bug fix * Add SortUp and SortDown icons to _fabricExtraIcons and change DetailsHeader.tsx to include new icons (microsoft#210) * Typo fix * Fix bug 239894 and 239885. Remove scroll bar when dropdown shows 1-3 people, fix item height under 480px breakpoint. * MDL2: Fabric-core ver bump (microsoft#214) * Depending upon fabric-core 4.0.0, adding neutralPrimary color * Remove extra icons file Fabric-core added 400+ icon classes * added support for deprecated remove value * fixing gulpfile * New MDL2 check, switched from SVG circle to css * Remove z-index from check and check background * Fix border radius on people picker persona component. * Change color of remove button to neutral primary and add border-radius to fix button hover * MDL2: Checkbox, ChoiceField fixes. Merge master (microsoft#244) * Persona: now renders children within the details, and overflow on details removed (microsoft#215) * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * resolve comments * resolve comments * Minor changes. * Adding @autoBind usage to a number of the components. (microsoft#233) * Updating GroupedList, Link, MarqueeSelection, Breadcrumb, Toggle, Callout * Updating autobinds for Checkbox, ColorPicker, CommandBar, ContextualMenu. * Updating SelectionZone autobinds. * Adding autobind to Utilities export. * Adding best practice notes. * Updating autobind for FocusZone. * Removing dead code. * DatePicker: Change text input validation to only call onSelectDate when text input is allowed (microsoft#230) * Fixed validation when allowTextInput is false * Fixed formatting * Update package.json * Dropdown: isDisabled is respected when the value changes. (microsoft#237) * v0.47.2 * Using react events * Fixing a minor bug in selection where isAllSelected is returning true when all items are unselectable. Added test, validated the fix works. (microsoft#240) * BaseComponent: Adding a _resolveRef helper to create memoized helpers to resolve refs. (microsoft#238) * Adding a _resolveRef helper to create memoized helpers to resolve refs. * Cleaning up tslint. * v0.47.3 * ContextualMenu: added tooltip and arialabel to menu and menu items. (microsoft#241) * v0.48.0 * Using css utility map * Use @autoBind and _resolveRef * Adding focus state * Adding isChecked state * Removing unneeded variables * ChoiceGroup using react events * Fixing type * MDL2: RTL and other fixes (microsoft#255) * Un-nesting CSS * Dropdown more consistent * Persona RTL fixes * RTL fixes * nit fixes * Removing Pivot item count example
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Met with design to hash out the missing redlines for the icon button. Updates icon button styles accordingly.
Targeted issue: 196739