Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Card): Add expandable card example #13000

Merged
merged 5 commits into from
May 6, 2020

Conversation

pompomon
Copy link
Contributor

@pompomon pompomon commented May 5, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Expandable card example with compose and custom styled elements

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 5, 2020

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 896 871 5000
Checkbox 1558 1633 5000
CheckboxBase 1314 1305 5000
ChoiceGroup 5049 5124 5000
ComboBox 1003 951 1000
CommandBar 7570 7803 1000
ContextualMenu 15234 14452 1000
DefaultButton 1100 1069 5000
DetailsRow 3422 3478 5000
DetailsRow (fast icons) 3436 3489 5000
DetailsRow without styles 3324 3307 5000
Dialog 1534 1461 1000
DocumentCardTitle with truncation 1590 1591 1000
Dropdown 2543 2564 5000
FocusZone 1608 1653 5000
IconButton 1767 1733 5000
Label 311 303 5000
Link 463 476 5000
MenuButton 1434 1467 5000
Nav 3016 3111 1000
Panel 1459 1363 1000
Persona 777 836 1000
Pivot 1255 1277 1000
PrimaryButton 1277 1271 5000
SearchBox 1304 1297 5000
Slider 1584 1481 5000
Spinner 365 397 5000
SplitButton 3258 3164 5000
Stack 470 492 5000
Stack with Intrinsic children 1106 1124 5000
Stack with Text children 4455 4514 5000
TagPicker 2763 2838 5000
Text 389 382 5000
TextField 1497 1434 5000
Toggle 927 911 5000
button 59 63 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.51 0.5 1.02:1 2000 1025
🦄 Button.Fluent 0.12 0.21 0.57:1 5000 616
🔧 Checkbox.Fluent 0.67 0.37 1.81:1 1000 666
🔧 Dialog.Fluent 0.37 0.21 1.76:1 5000 1874
🔧 Dropdown.Fluent 3.4 0.49 6.94:1 1000 3400
🔧 Icon.Fluent 0.16 0.05 3.2:1 5000 781
🎯 Image.Fluent 0.08 0.11 0.73:1 5000 400
🔧 Slider.Fluent 1.43 0.37 3.86:1 1000 1433
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 371
🦄 Tooltip.Fluent 0.09 17.14 0.01:1 5000 473

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
CarouselMinimalPerf.default 525 471 1.11:1
TextMinimalPerf.default 396 356 1.11:1
TreeWith60ListItems.default 240 216 1.11:1
MenuButtonMinimalPerf.default 1745 1582 1.1:1
ButtonSlotsPerf.default 698 642 1.09:1
RefMinimalPerf.default 212 195 1.09:1
AttachmentSlotsPerf.default 1249 1160 1.08:1
DividerMinimalPerf.default 386 360 1.07:1
ListCommonPerf.default 1112 1042 1.07:1
ListWith60ListItems.default 1258 1180 1.07:1
PopupMinimalPerf.default 271 253 1.07:1
ToolbarMinimalPerf.default 1099 1029 1.07:1
AlertMinimalPerf.default 342 323 1.06:1
Button.Fluent 616 580 1.06:1
AttachmentMinimalPerf.default 160 152 1.05:1
EmbedMinimalPerf.default 2206 2091 1.05:1
VideoMinimalPerf.default 691 660 1.05:1
CheckboxMinimalPerf.default 3050 2940 1.04:1
HeaderMinimalPerf.default 559 537 1.04:1
ItemLayoutMinimalPerf.default 1871 1798 1.04:1
TreeMinimalPerf.default 1279 1232 1.04:1
Text.Fluent 371 357 1.04:1
DropdownMinimalPerf.default 3382 3284 1.03:1
HeaderSlotsPerf.default 1632 1588 1.03:1
ProviderMinimalPerf.default 687 670 1.03:1
AccordionMinimalPerf.default 157 154 1.02:1
ChatDuplicateMessagesPerf.default 428 420 1.02:1
ListMinimalPerf.default 525 513 1.02:1
ProviderMergeThemesPerf.default 1671 1644 1.02:1
Slider.Fluent 1433 1403 1.02:1
Tooltip.Fluent 473 465 1.02:1
ChatMinimalPerf.default 662 655 1.01:1
HierarchicalTreeMinimalPerf.default 1084 1077 1.01:1
LabelMinimalPerf.default 438 432 1.01:1
PortalMinimalPerf.default 331 328 1.01:1
ReactionMinimalPerf.default 2023 2004 1.01:1
SliderMinimalPerf.default 1414 1396 1.01:1
SplitButtonMinimalPerf.default 3541 3502 1.01:1
StatusMinimalPerf.default 720 713 1.01:1
TableMinimalPerf.default 406 400 1.01:1
CustomToolbarPrototype.default 3555 3524 1.01:1
TooltipMinimalPerf.default 711 703 1.01:1
Dialog.Fluent 1874 1853 1.01:1
Icon.Fluent 781 772 1.01:1
CardMinimalPerf.default 594 596 1:1
DialogMinimalPerf.default 1810 1814 1:1
RadioGroupMinimalPerf.default 631 631 1:1
DropdownManyItemsPerf.default 1359 1371 0.99:1
MenuMinimalPerf.default 1971 1982 0.99:1
Dropdown.Fluent 3400 3425 0.99:1
AnimationMinimalPerf.default 697 712 0.98:1
ChatWithPopoverPerf.default 575 585 0.98:1
GridMinimalPerf.default 719 737 0.98:1
LoaderMinimalPerf.default 766 782 0.98:1
SegmentMinimalPerf.default 979 994 0.98:1
Checkbox.Fluent 666 679 0.98:1
FormMinimalPerf.default 838 864 0.97:1
TextAreaMinimalPerf.default 494 510 0.97:1
BoxMinimalPerf.default 345 360 0.96:1
ImageMinimalPerf.default 391 406 0.96:1
LayoutMinimalPerf.default 611 638 0.96:1
ListNestedPerf.default 933 970 0.96:1
Avatar.Fluent 1025 1063 0.96:1
Image.Fluent 400 415 0.96:1
AvatarMinimalPerf.default 512 538 0.95:1
IconMinimalPerf.default 711 747 0.95:1
InputMinimalPerf.default 968 1028 0.94:1
FlexMinimalPerf.default 289 312 0.93:1
ButtonMinimalPerf.default 156 180 0.87:1

@size-auditor
Copy link

size-auditor bot commented May 5, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8d7faca2da69b5c0203041e3397bf0edf9210f48 (build)

@pompomon pompomon merged commit cb215f4 into microsoft:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants