feat(Animation): update animations for Teams theme #13046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d369a0b09170eeae92a2e494ba471dbe42dca87c (build) |
# Conflicts: # packages/fluentui/state/src/managers/carouselManager.ts
mnajdova
commented
May 8, 2020
| 'carousel-slide-to-next-enter': slideAnimations.slideLeftEnterMedium, | ||
| 'carousel-slide-to-next-exit': slideAnimations.slideLeftExitMedium, | ||
| 'carousel-slide-to-previous-enter': slideAnimations.slideRightEnterMedium, | ||
| 'carousel-slide-to-previous-exit': slideAnimations.slideRightExitMedium, |
There was a problem hiding this comment.
These are not used anymore
pompomon
approved these changes
May 12, 2020
…e' into feat/animation-update-teams-theme
|
@mnajdova This has merge conflicts now. |
# Conflicts: # packages/fluentui/CHANGELOG.md
mnajdova
commented
May 20, 2020
packages/fluentui/react-northstar/src/themes/teams/components/Button/buttonStyles.ts
Outdated
Show resolved
Hide resolved
…Button/buttonStyles.ts
miroslavstastny
pushed a commit
to levithomason/fluentui
that referenced
this pull request
Jun 8, 2020
* -animation updates * fixed names * -fixed Carousel * -ts errors * -reverted changes * -reverted changes * reverted changes * -updated changelog * reverted changes * -button animations fixes * Update packages/fluentui/react-northstar/src/themes/teams/components/Button/buttonStyles.ts
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
Animations duration/timing functions and names were updated. If there were some usages, the best advice is to contact the motion team for guidance on which durations/timing functions should be used.