Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(MenuDivider): Convert to RFC #13069

Merged
merged 8 commits into from
May 11, 2020

Conversation

assuncaocharles
Copy link
Contributor

@assuncaocharles assuncaocharles commented May 8, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

BREAKING CHANGES

This PR converts MenuDivider component to be functional. Restricting props set that will be passed to styles functions.

Related to #12237

Prop sets

MenuDivider
hasContent
vertical
inSubmenu
primary

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot
Copy link
Contributor

msft-github-bot commented May 8, 2020

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 777 797 5000
Checkbox 1506 1598 5000
CheckboxBase 1196 1235 5000
CheckboxNext 1484 1496 5000
ChoiceGroup 4770 4706 5000
ComboBox 849 879 1000
CommandBar 7856 7339 1000
ContextualMenu 14099 13992 1000
DefaultButton 1031 1038 5000
DetailsRow 3276 3223 5000
DetailsRow (fast icons) 3237 3314 5000
DetailsRow without styles 3072 3097 5000
Dialog 1402 1377 1000
DocumentCardTitle with truncation 1701 1626 1000
Dropdown 2331 2328 5000
FocusZone 1553 1572 5000
IconButton 1621 1625 5000
Label 297 300 5000
Link 435 445 5000
MenuButton 1370 1369 5000
Nav 3356 3026 1000
Panel 1454 1473 1000
Persona 808 813 1000
Pivot 1293 1294 1000
PrimaryButton 1165 1158 5000
SearchBox 1191 1208 5000
Slider 1424 1403 5000
Spinner 374 363 5000
SplitButton 2933 2960 5000
Stack 437 447 5000
Stack with Intrinsic children 1108 1061 5000
Stack with Text children 3949 3961 5000
TagPicker 2652 2603 5000
Text 368 363 5000
TextField 1330 1296 5000
Toggle 835 873 5000
button 56 52 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.46 0.46 1:1 2000 917
🦄 Button.Fluent 0.1 0.18 0.56:1 5000 517
🔧 Checkbox.Fluent 0.65 0.33 1.97:1 1000 646
🔧 Dialog.Fluent 0.35 0.2 1.75:1 5000 1731
🔧 Dropdown.Fluent 3.29 0.4 8.23:1 1000 3286
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 710
🎯 Image.Fluent 0.07 0.1 0.7:1 5000 348
🔧 Slider.Fluent 1.41 0.32 4.41:1 1000 1409
🔧 Text.Fluent 0.06 0.02 3:1 5000 316
🦄 Tooltip.Fluent 0.09 18.23 0:1 5000 466

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
HeaderMinimalPerf.default 562 485 1.16:1
AttachmentMinimalPerf.default 149 134 1.11:1
VideoMinimalPerf.default 613 563 1.09:1
ButtonMinimalPerf.default 163 154 1.06:1
ChatMinimalPerf.default 613 580 1.06:1
PopupMinimalPerf.default 266 252 1.06:1
PortalMinimalPerf.default 315 296 1.06:1
Tooltip.Fluent 466 439 1.06:1
AccordionMinimalPerf.default 138 132 1.05:1
ListNestedPerf.default 882 844 1.05:1
RadioGroupMinimalPerf.default 551 523 1.05:1
CardMinimalPerf.default 553 532 1.04:1
CarouselMinimalPerf.default 456 440 1.04:1
DropdownManyItemsPerf.default 1359 1312 1.04:1
LoaderMinimalPerf.default 776 747 1.04:1
ReactionMinimalPerf.default 1900 1824 1.04:1
Avatar.Fluent 917 882 1.04:1
Button.Fluent 517 499 1.04:1
Checkbox.Fluent 646 624 1.04:1
Icon.Fluent 710 682 1.04:1
BoxMinimalPerf.default 315 307 1.03:1
FormMinimalPerf.default 736 714 1.03:1
HeaderSlotsPerf.default 1461 1415 1.03:1
HierarchicalTreeMinimalPerf.default 961 929 1.03:1
ItemLayoutMinimalPerf.default 1645 1593 1.03:1
SegmentMinimalPerf.default 928 905 1.03:1
ToolbarMinimalPerf.default 831 808 1.03:1
ButtonSlotsPerf.default 609 598 1.02:1
DialogMinimalPerf.default 1728 1690 1.02:1
LabelMinimalPerf.default 381 375 1.02:1
ListCommonPerf.default 955 938 1.02:1
ListMinimalPerf.default 451 443 1.02:1
ListWith60ListItems.default 1127 1107 1.02:1
TreeMinimalPerf.default 1150 1129 1.02:1
Slider.Fluent 1409 1383 1.02:1
MenuMinimalPerf.default 1841 1825 1.01:1
SplitButtonMinimalPerf.default 3377 3329 1.01:1
TreeWith60ListItems.default 218 215 1.01:1
Dialog.Fluent 1731 1708 1.01:1
EmbedMinimalPerf.default 1953 1951 1:1
InputMinimalPerf.default 983 987 1:1
MenuButtonMinimalPerf.default 1522 1515 1:1
ProviderMergeThemesPerf.default 1700 1695 1:1
RefMinimalPerf.default 207 208 1:1
CustomToolbarPrototype.default 3707 3720 1:1
Dropdown.Fluent 3286 3279 1:1
Image.Fluent 348 347 1:1
DividerMinimalPerf.default 322 324 0.99:1
DropdownMinimalPerf.default 3244 3290 0.99:1
FlexMinimalPerf.default 272 276 0.99:1
ProviderMinimalPerf.default 648 655 0.99:1
TableMinimalPerf.default 347 352 0.99:1
TooltipMinimalPerf.default 710 718 0.99:1
AttachmentSlotsPerf.default 1104 1128 0.98:1
ChatWithPopoverPerf.default 581 594 0.98:1
CheckboxMinimalPerf.default 2869 2927 0.98:1
LayoutMinimalPerf.default 527 538 0.98:1
SliderMinimalPerf.default 1379 1403 0.98:1
StatusMinimalPerf.default 646 657 0.98:1
TextAreaMinimalPerf.default 438 449 0.98:1
AnimationMinimalPerf.default 612 629 0.97:1
AvatarMinimalPerf.default 479 492 0.97:1
Text.Fluent 316 327 0.97:1
ChatDuplicateMessagesPerf.default 406 423 0.96:1
ImageMinimalPerf.default 340 354 0.96:1
TextMinimalPerf.default 323 338 0.96:1
GridMinimalPerf.default 646 681 0.95:1
IconMinimalPerf.default 605 635 0.95:1
AlertMinimalPerf.default 280 297 0.94:1

@size-auditor
Copy link

size-auditor bot commented May 8, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e4d06210e5d6a88c42198e69f46187e0afa8b4cc (build)

assuncaocharles and others added 4 commits May 11, 2020 13:04
@assuncaocharles assuncaocharles merged commit dacf00d into microsoft:master May 11, 2020
@assuncaocharles assuncaocharles deleted the chore/menu-divider branch May 11, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants