fix(CarouselNavigation): enable back focus zone in carousel navigation #13086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 3, 2020 14:52
kolaps33
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
kolaps33
changed the title
kolaps33
changed the title
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
layershifter
approved these changes
May 11, 2020
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 88f4e59ffac3a6b070a1ed34ef2f26509e688f22 (build) |
jurokapsiar
approved these changes
May 11, 2020
silviuaavram
approved these changes
May 11, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow keys navigation in the carousel navigation list stops to work.
Description of changes
Root cause was that focus zone was not adding to the tablist after convert to FC
Adding function which will allow it.
Focus areas to test
Navigate under the carousel into the navigation tablist
Use left/right arrow keys
Expected Result
Left/Right arrow keys navigate to previous/next tab element (bullet)
Microsoft Reviewers: Open in CodeFlow