-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(RadioGroup): Update examples to enable input for in the tab order inside Radio Group #13110
fix(RadioGroup): Update examples to enable input for in the tab order inside Radio Group #13110
Conversation
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 767c1b15e2dbc67d98d1f36d93d027e7cf881459 (build) |
This example is just so weird. We removed the input from the tab order just to put some custom keyboard handling in this PR. Why was the input removed from the tab order from the first place? Edit: maybe because we are focusing the whole wrapper on tab instead of the radio button. Which is not a radio button. This looks just so different from what an |
I was also wondering if it was really a problem with the behavior or just a matter of the example that explicitly remove the input from tab order |
Pull request checklist
$ yarn change
Description of changes
Update examples to enable input for in the tab order inside Radio Group
Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow