Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Card): Update card padding/margin #13158

Merged
merged 2 commits into from
May 15, 2020

Conversation

pompomon
Copy link
Contributor

@pompomon pompomon commented May 14, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Update Card padding/margin style definitions

Microsoft Reviewers: Open in CodeFlow

@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label May 14, 2020
@pompomon pompomon changed the title Update card padding/margin chore(Card): Update card padding/margin May 14, 2020
@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Master Ticks PR Ticks Iterations Status
BaseButton 853 849 5000
Checkbox 1616 1709 5000
CheckboxBase 1328 1360 5000
CheckboxNext 1560 1587 5000
ChoiceGroup 5001 4983 5000
ComboBox 999 895 1000
CommandBar 7132 7480 1000
ContextualMenu 14228 14213 1000
DefaultButton 1068 1072 5000
DetailsRow 3278 3377 5000
DetailsRow (fast icons) 3280 3292 5000
DetailsRow without styles 3214 3128 5000
Dialog 1430 1457 1000
DocumentCardTitle with truncation 1518 1486 1000
Dropdown 2314 2405 5000
FocusZone 1500 1510 5000
IconButton 1715 1651 5000
Label 305 316 5000
Link 439 444 5000
MenuButton 1359 1409 5000
Nav 2978 2946 1000
Panel 1339 1333 1000
Persona 792 793 1000
Pivot 1246 1353 1000
PrimaryButton 1177 1175 5000
SearchBox 1234 1249 5000
Slider 1382 1461 5000
Spinner 350 352 5000
SplitButton 2887 2923 5000
Stack 461 460 5000
Stack with Intrinsic children 1037 1034 5000
Stack with Text children 3980 3987 5000
TagPicker 2552 2705 5000
Text 370 372 5000
TextField 1330 1335 5000
Toggle 850 858 5000
button 56 60 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.48 0.46 1.04:1 2000 961
🦄 Button.Fluent 0.11 0.2 0.55:1 5000 570
🔧 Checkbox.Fluent 0.63 0.34 1.85:1 1000 630
🔧 Dialog.Fluent 0.35 0.2 1.75:1 5000 1755
🔧 Dropdown.Fluent 3.15 0.43 7.33:1 1000 3154
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 692
🎯 Image.Fluent 0.08 0.1 0.8:1 5000 378
🔧 Slider.Fluent 1.33 0.37 3.59:1 1000 1329
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 348
🦄 Tooltip.Fluent 0.09 17.15 0.01:1 5000 440

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PopupMinimalPerf.default 247 230 1.07:1
ReactionMinimalPerf.default 403 380 1.06:1
ChatMinimalPerf.default 646 615 1.05:1
RefMinimalPerf.default 200 190 1.05:1
ButtonMinimalPerf.default 169 162 1.04:1
ButtonSlotsPerf.default 591 567 1.04:1
DividerMinimalPerf.default 345 333 1.04:1
DropdownManyItemsPerf.default 1299 1252 1.04:1
ListMinimalPerf.default 512 491 1.04:1
ListNestedPerf.default 936 899 1.04:1
ProviderMinimalPerf.default 631 606 1.04:1
RadioGroupMinimalPerf.default 601 578 1.04:1
SegmentMinimalPerf.default 349 337 1.04:1
TreeMinimalPerf.default 1284 1232 1.04:1
GridMinimalPerf.default 699 679 1.03:1
LayoutMinimalPerf.default 598 582 1.03:1
ListWith60ListItems.default 1162 1127 1.03:1
SliderMinimalPerf.default 1326 1288 1.03:1
TableMinimalPerf.default 401 388 1.03:1
Avatar.Fluent 961 931 1.03:1
AlertMinimalPerf.default 315 308 1.02:1
AnimationMinimalPerf.default 659 646 1.02:1
AttachmentMinimalPerf.default 153 150 1.02:1
FormMinimalPerf.default 774 762 1.02:1
MenuMinimalPerf.default 692 681 1.02:1
PortalMinimalPerf.default 316 310 1.02:1
ProviderMergeThemesPerf.default 1556 1528 1.02:1
TreeWith60ListItems.default 227 222 1.02:1
Checkbox.Fluent 630 619 1.02:1
BoxMinimalPerf.default 326 322 1.01:1
CardMinimalPerf.default 564 557 1.01:1
ChatDuplicateMessagesPerf.default 407 404 1.01:1
DialogMinimalPerf.default 1735 1715 1.01:1
DropdownMinimalPerf.default 3070 3034 1.01:1
HeaderSlotsPerf.default 1509 1501 1.01:1
InputMinimalPerf.default 960 955 1.01:1
ItemLayoutMinimalPerf.default 1734 1710 1.01:1
Button.Fluent 570 562 1.01:1
Slider.Fluent 1329 1322 1.01:1
AttachmentSlotsPerf.default 1114 1116 1:1
HierarchicalTreeMinimalPerf.default 1021 1026 1:1
LabelMinimalPerf.default 414 414 1:1
LoaderMinimalPerf.default 748 745 1:1
MenuButtonMinimalPerf.default 1593 1590 1:1
SplitButtonMinimalPerf.default 3348 3335 1:1
StatusMinimalPerf.default 690 687 1:1
TextMinimalPerf.default 364 363 1:1
ToolbarMinimalPerf.default 876 874 1:1
Dialog.Fluent 1755 1762 1:1
Dropdown.Fluent 3154 3149 1:1
Text.Fluent 348 347 1:1
CarouselMinimalPerf.default 461 467 0.99:1
EmbedMinimalPerf.default 1941 1963 0.99:1
FlexMinimalPerf.default 284 288 0.99:1
ListCommonPerf.default 991 1004 0.99:1
TextAreaMinimalPerf.default 481 484 0.99:1
CustomToolbarPrototype.default 3423 3453 0.99:1
Image.Fluent 378 383 0.99:1
Tooltip.Fluent 440 446 0.99:1
CheckboxMinimalPerf.default 2746 2795 0.98:1
HeaderMinimalPerf.default 497 508 0.98:1
VideoMinimalPerf.default 643 653 0.98:1
IconMinimalPerf.default 659 682 0.97:1
AvatarMinimalPerf.default 474 492 0.96:1
ChatWithPopoverPerf.default 507 532 0.95:1
ImageMinimalPerf.default 364 385 0.95:1
TooltipMinimalPerf.default 700 740 0.95:1
Icon.Fluent 692 729 0.95:1
AccordionMinimalPerf.default 139 149 0.93:1

@size-auditor
Copy link

size-auditor bot commented May 14, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 06007a4def103f962428ad65e96af450a1c6f569 (build)

@pompomon pompomon merged commit 6b7c58a into microsoft:master May 15, 2020
@pompomon pompomon deleted the chore/card-styles branch May 15, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants